-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linting): Add Taskfile tasks to run linters. #76
Merged
Merged
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ba6986c
support linter in task
haiqi96 f0ec0b0
fix
haiqi96 0366aec
fix permission
haiqi96 66d5945
update version
haiqi96 6087f0d
Properly update dependency and add rules to overwrite extern indentation
haiqi96 c4f00f6
Apply linter to file
haiqi96 79ddd8c
Some other changes
haiqi96 d2e3ac2
Update github flow to run linter properly
haiqi96 eb460cd
remove deprecated dependency from workflow
haiqi96 9dd98ff
Fix yml based on linter recommendation
haiqi96 6a81eb7
Remove overkill script
haiqi96 b64d77e
Remove overkill script
haiqi96 7f1d61d
Revert G_ prefix change
haiqi96 151cf8f
temp
haiqi96 eba2157
Merge branch 'main' into move_work_around
haiqi96 51f8726
updates
haiqi96 95fd572
Let task use a list of directories instead of hardcoded ones in the l…
haiqi96 0a2a971
Update readme
haiqi96 1ddfc77
Fix reference
haiqi96 b0c0632
Simplify commands
haiqi96 75ad8f6
Add mypy and docformatter to the linter task
haiqi96 be7c738
Update readme
haiqi96 469a294
Add missing dependency
haiqi96 9b42c6d
Update util version
haiqi96 1f1ba36
Use latest clang-format and clang-tidy from yscope-dev-utils
haiqi96 076d02b
Merge branch 'main' into task-linter
haiqi96 c1da5e6
Slight customization
haiqi96 952be37
Slight customization
haiqi96 22afa5b
Revert "Slight customization"
haiqi96 a9f3441
Revert "Slight customization"
haiqi96 6604c01
Update yscope-dev-utils
haiqi96 cdc90da
Revert "Revert "Slight customization""
haiqi96 32754d6
Revert "Revert "Slight customization""
haiqi96 99f56bf
Apply some code review suggestions
haiqi96 3d37bc3
Apply more code review suggestions
haiqi96 b2e7e35
Update README.md
haiqi96 f0fd719
reorder
haiqi96 8189c1d
Update ruff flag
haiqi96 083d397
Update docs/conf/conf.py
haiqi96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,41 @@ | ||
name: "Bug Report" | ||
description: Report software deficiencies | ||
description: "Report software deficiencies" | ||
labels: ["bug"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Use this form to report any functional or performance bugs you've found in the software. | ||
|
||
Be sure to check if your [issue](https://github.com/y-scope/clp-ffi-py/issues) has already been reported. | ||
- type: "markdown" | ||
attributes: | ||
value: | | ||
Use this form to report any functional or performance bugs you've found in the software. | ||
|
||
- type: textarea | ||
attributes: | ||
label: Bug | ||
description: "Describe what's wrong and if applicable, what you expected instead." | ||
validations: | ||
required: true | ||
Be sure to check if your [issue](https://github.com/y-scope/clp-ffi-py/issues) has already | ||
been reported. | ||
haiqi96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- type: input | ||
attributes: | ||
label: clp-ffi-py version | ||
description: "The release version number or development commit hash that has the bug." | ||
placeholder: "Version number or commit hash" | ||
validations: | ||
required: true | ||
- type: "textarea" | ||
attributes: | ||
label: "Bug" | ||
description: "Describe what's wrong and if applicable, what you expected instead." | ||
validations: | ||
required: true | ||
haiqi96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- type: textarea | ||
attributes: | ||
label: Environment | ||
description: "The environment in which you're using clp-ffi-py." | ||
placeholder: "OS version, docker version, etc." | ||
validations: | ||
required: true | ||
- type: "input" | ||
attributes: | ||
label: "clp-ffi-py version" | ||
description: "The release version number or development commit hash that has the bug." | ||
placeholder: "Version number or commit hash" | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
attributes: | ||
label: Reproduction steps | ||
description: "List each step required to reproduce the bug." | ||
validations: | ||
required: true | ||
- type: "textarea" | ||
attributes: | ||
label: "Environment" | ||
description: "The environment in which you're using clp-ffi-py." | ||
placeholder: "OS version, docker version, etc." | ||
validations: | ||
required: true | ||
haiqi96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- type: "textarea" | ||
attributes: | ||
label: "Reproduction steps" | ||
description: "List each step required to reproduce the bug." | ||
validations: | ||
required: true | ||
haiqi96 marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only indentation changes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,22 @@ | ||
name: "Feature/Change Request" | ||
description: Request a feature or change | ||
description: "Request a feature or change" | ||
labels: ["enhancement"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Use this form to request a feature/change in the software, or the project as a whole. | ||
- type: "markdown" | ||
attributes: | ||
value: | | ||
Use this form to request a feature/change in the software, or the project as a whole. | ||
|
||
- type: textarea | ||
attributes: | ||
label: Request | ||
description: "Describe your request and why it's important." | ||
validations: | ||
required: true | ||
|
||
- type: textarea | ||
attributes: | ||
label: Possible implementation | ||
description: "Describe any implementations you have in mind." | ||
validations: | ||
required: true | ||
- type: "textarea" | ||
attributes: | ||
label: "Request" | ||
description: "Describe your request and why it's important." | ||
validations: | ||
required: true | ||
|
||
- type: "textarea" | ||
attributes: | ||
label: "Possible implementation" | ||
description: "Describe any implementations you have in mind." | ||
validations: | ||
required: true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only indentation and quote changes