Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pnp): normalize resolve.exports errors #3921

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

The errors thrown by the resolve.exports package weren't wrapped, causing us to display stack traces that included unnecessary information.

How did you fix it?

Wrapped the resolve.exports errors so that they can have pnpCode and data properties (and a code property too, but lukeed/resolve.exports#6 is required for proper validation and error codes).

I also added the extensions property to the data of QUALIFIED_PATH_RESOLUTION_FAILED errors for consistency.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit f38c308 into master Jan 5, 2022
@arcanis arcanis deleted the paul/refactor/exports-errors branch January 5, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants