feat: support configuring link mode across plugins #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove stay console.log Changes to be committed: modified: packages/acceptance-tests/pkg-tests-specs/sources/features/pnpm.test.ts modified: packages/plugin-nm/sources/NodeModulesLinker.ts modified: packages/plugin-pnp/sources/index.ts
merceyz
changed the title
|
We'll try to review when we get the chance, no need to rush. |
Understood. More asking about the process! |
|
The PR looks good to me, I'm not sure about |
arcanis
requested changes
Oct 31, 2022
…erLinkMode)/support-configuring-link-mode-accross-plugins
larixer
reviewed
Oct 31, 2022
jeff-wishnie
requested review from
larixer and
arcanis
and removed request for
larixer
larixer
previously approved these changes
Nov 1, 2022
|
Thanks! |
jeff-wishnie
deleted the
feat(folderLinkMode)/support-configuring-link-mode-accross-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When creating package and workspace links in
node_modulesfolders theplugin-nmandplugin-pnpmnode-linkers use symbolic-links on *nix platforms and Windows Junctions on Windows.Because Junctions are always absolute paths, this creates potential inconsistencies in behavior across platforms--with realtive-path symlinks created on *nix and absolute-path Junctions on Windows.
This is particularly problematic when mounting local folders into Docker containers as volumes and abolsute-path links will be broken inside the container.
PR #4981 added a configuration setting to use symlinks on WIndows (which may be relative-path) in with
nodeLinker: node-modules, supporting container-compatible consistent behavior across *nix and Windows.This PR, per @merceyz 's request adds the same option for
plugin-pnpmand refactors the setting intoplugin-pnp...
How did you fix it?
Generalized the setting
nmFolderLinkModeby:nodeLinkerFolderLinkModeplugin-nmtoplugin-pnpQUESTION Is this the correct place to place the setting? It is now used by both
plugin-nmandplugin-pnpmso it should not be in one or the other of those plugins. I placed it inplugin-pnpbecause it is related (subservient) tonodeLinker, which is inplugin-pnpUpdated
plugin-nmto use the renamed settingUpdated
plugin-pnpmto respect the settingThe PR also generalizes a couple helpers out of the integration tests of the feature from
plugin-nmso that they can also be used in integration tests ofplugin-pnpm...
Checklist