Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リモートクリップ説明文がローカル仕様になってる問題の修正 #466

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Sep 19, 2024

What

リモートユーザーのクリップ説明文に含まれるメンションと絵文字をリモート仕様にした
絵文字の情報が無かったからノートと同じ仕様でAPIに追加してある

Why

fix: #464

Additional info (optional)

リモートの絵文字情報をredisForRemoteApisに入れてるからメモリ消費が気になるかも

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -85827,6 +85827,16 @@
           },
           "notesCount": {
             "type": "integer"
+          },
+          "emojis": {
+            "type": "object",
+            "additionalProperties": {
+              "anyOf": [
+                {
+                  "type": "string"
+                }
+              ]
+            }
           }
         },
         "required": [

Get diff files from Workflow Page

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@kozakura913 kozakura913 self-assigned this Sep 19, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 15.21739% with 78 lines in your changes missing coverage. Please review.

Project coverage is 40.43%. Comparing base (5b803db) to head (53ebe13).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/misc/remote-api-utils.ts 4.00% 72 Missing ⚠️
packages/backend/src/core/ClipService.ts 33.33% 2 Missing ⚠️
...ges/backend/src/server/api/endpoints/clips/show.ts 0.00% 2 Missing ⚠️
...es/backend/src/server/api/endpoints/users/clips.ts 50.00% 1 Missing ⚠️
packages/frontend/src/pages/clip.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #466      +/-   ##
===========================================
+ Coverage    38.69%   40.43%   +1.73%     
===========================================
  Files         1662     1666       +4     
  Lines       217457   223989    +6532     
  Branches      3753     3770      +17     
===========================================
+ Hits         84154    90576    +6422     
- Misses      132659   132804     +145     
+ Partials       644      609      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit b761657 into yojo-art:develop Sep 19, 2024
27 of 28 checks passed
@kozakura913 kozakura913 deleted the fix_464 branch September 19, 2024 12:34
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リモートクリップの説明文に含まれる@がローカル
2 participants