-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リモートクリップ説明文がローカル仕様になってる問題の修正 #466
Merged
Merged
+97
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
이 PR에 의한 api.json 차이 차이점은 여기에서 볼 수 있음--- base
+++ head
@@ -85827,6 +85827,16 @@
},
"notesCount": {
"type": "integer"
+ },
+ "emojis": {
+ "type": "object",
+ "additionalProperties": {
+ "anyOf": [
+ {
+ "type": "string"
+ }
+ ]
+ }
}
},
"required": [ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #466 +/- ##
===========================================
+ Coverage 38.69% 40.43% +1.73%
===========================================
Files 1662 1666 +4
Lines 217457 223989 +6532
Branches 3753 3770 +17
===========================================
+ Hits 84154 90576 +6422
- Misses 132659 132804 +145
+ Partials 644 609 -35 ☔ View full report in Codecov by Sentry. |
penginn-net
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
リモートユーザーのクリップ説明文に含まれるメンションと絵文字をリモート仕様にした
絵文字の情報が無かったからノートと同じ仕様でAPIに追加してある
Why
fix: #464
Additional info (optional)
リモートの絵文字情報をredisForRemoteApisに入れてるからメモリ消費が気になるかも
Checklist