Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 絵文字を登録する際にシステムユーザーとして再アップロード #510

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Oct 18, 2024

What

絵文字を登録する際にシステムユーザーとして再アップロード

Why

登録したユーザーがアカウントを削除しても絵文字が消えないように

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.98%. Comparing base (10e333b) to head (355c669).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/CustomEmojiService.ts 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
- Coverage    59.99%   59.98%   -0.02%     
===========================================
  Files          882      882              
  Lines       102328   102338      +10     
  Branches      2683     2629      -54     
===========================================
- Hits         61394    61389       -5     
- Misses       40877    40892      +15     
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 self-assigned this Oct 18, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Oct 18, 2024
@kozakura913 kozakura913 merged commit d070349 into yojo-art:develop Oct 18, 2024
25 of 27 checks passed
noridev added a commit to kokonect-link/cherrypick that referenced this pull request Oct 31, 2024
…pick#510)

  - 이모지를 등록한 사용자가 계정을 삭제하면 이모지도 같이 삭제되기 때문에 변경되었습니다.
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants