Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend): ノート詳細画面でリアクション出来ない #584

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Dec 21, 2024

What

呼び出す関数のミスを修正

Why

ノート詳細画面でリアクション出来ないため

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Sorry, something went wrong.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.86%. Comparing base (9f83972) to head (7ff6c64).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #584       +/-   ##
============================================
- Coverage    40.05%   19.86%   -20.19%     
============================================
  Files         1696      797      -899     
  Lines       235895   123092   -112803     
  Branches      3935     1041     -2894     
============================================
- Hits         94493    24457    -70036     
+ Misses      140738    98030    -42708     
+ Partials       664      605       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net force-pushed the fix-note-detail-react2 branch from a562987 to c1464ea Compare December 21, 2024 10:34
@penginn-net penginn-net merged commit af6ad49 into yojo-art:develop Dec 21, 2024
21 of 22 checks passed
@penginn-net penginn-net deleted the fix-note-detail-react2 branch December 21, 2024 10:44
@kozakura913 kozakura913 added this to the 1.2.2 milestone Dec 22, 2024
@kozakura913 kozakura913 mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants