GPClient does not launch default browser after upgrade to 2.2.0

[chaitanyanettem]

Describe the bug
The default browser isn't launched. Looking at the logs shows that gpclient is waiting for browser authentication to complete which never happens because the browser tab isn't launched.

Expected behavior
Browser tab for authentication should be opened and login should proceed. If I disable using default browsers, login proceeds as expected.

Screenshots
The app stays hung here -

(Have removed portal address)

Logs

(gpgui:57183): Gdk-CRITICAL **: 19:50:38.454: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Connecting to the portal: v**********m...
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Trying to connect the gateway directly...
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Try login the gateway with prelogin...
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Gateway prelogin, gateway: v**********m...
[2024-05-07T14:20:39Z INFO  gpapi::portal::prelogin] Gateway prelogin with user_agent: PAN GlobalProtect/6.0.1-19 (Linux Ubuntu 22.04.4 LTS)
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Authenticating gateway...
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Launching SAML authentication...
[2024-05-07T14:20:39Z INFO  gpauth::cli] gpauth started: 2.2.0 (2024-04-30)
[2024-05-07T14:20:39Z INFO  gpauth::cli] Please continue the authentication process in the default browser
[2024-05-07T14:20:39Z INFO  gpgui::portal_connector] Waiting for the user to authenticate in the browser...

Environment:

• OS: Ubuntu 22.04
• Desktop Environment: i3-wm
• Output of ps aux | grep 'gnome-keyring\|kwalletd5' | grep -v grep: [Required for secure store error]

$ ps aux | grep 'gnome-keyring\|kwalletd5' | grep -v grep
anon+    2717  0.0  0.0 240884  7096 ?        Sl   19:33   0:00 /usr/bin/gnome-keyring-daemon --daemonize --login
anon+    3615  0.0  0.0 240624  8160 ?        Sl   19:33   0:00 /usr/bin/gnome-keyring-daemon --start --foreground --components=secrets

• Is remote SSH? No

[yuezk]

Hi @chaitanyanettem can you help try this to see if it works for you.

1. Click the top left menu, select Clear Credentials
2. Click the icon of the portal input
   
3. Select the Portal Server
   
4. Connect it again.

[yuezk]

Hi @chaitanyanettem, we did some modifications for the default browser-related feature in 2.2.0. But it works for me on all my test OS. I have restored the modification in 2.2.1, can you help upgrade it and see if it works for you? Thanks.

[chaitanyanettem]

Thanks for the quick turn around. Your suggestion about clearing credentials and selecting Portal Gateway did not make any difference.

However after upgrade to 2.2.1 browser authentication is working again.

[yuezk]

Glad to see it works for you again. Looks like the modification in 2.2.0 will break the browser auth for some OS or desktop environments. I'm closing it for now.

[thaikien]

Hello,
I got the same problem with gpclient 2.3.1 (2024-05-22) in CLI mode on Ubuntu 22.04.4.
My default browser is Chrome.
Here are the last log lines from the command:

[2024-06-14T10:35:41Z INFO  gpauth::cli] Please continue the authentication process in the default browser
[2024-06-14T10:35:41Z INFO  gpclient::connect] Waiting for the browser authentication to complete...
[2024-06-14T10:35:41Z INFO  gpclient::connect] Listening authentication data on port 44651

Is there anything that I can do?

[yuezk]

@thaikien I tried to fix this in the dev branch, can you help install the snapshot version from https://github.com/yuezk/GlobalProtect-openconnect/releases/tag/snapshot to see if it works for you now? Thanks.

[thaikien]

@yuezk , it works much better now with the snapshot version. Thank you so much.

I look forward to using your next release version.

[yuezk]

@thaikien I will release a new version this weekend.