Fix circular dependency in setup.py #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing this package in a new virtualenv fails because setup.py tries to import pyod which in turn tries to import all its dependencies (numpy is in the error message in particular). However, it's setup.py's responsibility to install numpy and it gets imported before it's installed.
Fixing this by decoupling the version string from the pyod init file. For reference, this is the error we were seeing prior to the fix: