Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global execution context for all tests #28

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

aeons
Copy link
Contributor

@aeons aeons commented Aug 18, 2017

Update the rest of the tests to use the global execution context instead of a single threaded executor.

@zainab-ali
Copy link
Owner

I've actually managed to reproduce this one locally (yay!).

According to the spec, calls to request after cancel should be noops. It also implies that they should be run synchronously. Unfortunately, the code for enqueueing is run asynchronously, such that the order of request / cancel operations isn't guaranteed.

This was broken before and has been lurking for a while 😞

One way of fixing this is to run enqueue synchronously with unsafeRunSync, which would mean using IO as a concrete instead of F. I'd rather not do that, and there's probably a better solution.

I'm going to merge this PR in in any case - it isn't the cause of the bug, it just surfaces it.

@aeons
Copy link
Contributor Author

aeons commented Aug 18, 2017

I actually thought that @rossabaker fixed this in f57c9be.

@rossabaker
Copy link
Contributor

I fixed that one and unfixed it and thought it was still fixed. I think @zainab-ali is right. I'll look for my fix and comment on other ticket.

@zainab-ali
Copy link
Owner

This has been fixed in v0.2.3

@aeons aeons deleted the test-ec branch October 22, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants