Upgrade to fs2-1.0.0-M1 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 4 4
Lines 78 78
Branches 2 2
=======================================
Hits 73 73
Misses 5 5
Continue to review full report at Codecov.
|
zainab-ali
approved these changes
Jun 4, 2018
| @@ -3,7 +3,7 @@ import ReleaseTransformations._ | |||
|
|
|||
| lazy val buildSettings = Seq( | |||
| organization := "com.github.zainab-ali", | |||
| crossScalaVersions := List("2.12.4", "2.11.12"), | |||
| crossScalaVersions := List("2.12.6", "2.11.12"), | |||
| final class StreamSubscriber[F[_], A](val sub: StreamSubscriber.FSM[F, A])(implicit A: Effect[F], | ||
| ec: ExecutionContext) | ||
| final class StreamSubscriber[F[_], A](val sub: StreamSubscriber.FSM[F, A])(implicit F: ConcurrentEffect[F], | ||
| timer: Timer[F]) |
There was a problem hiding this comment.
I was a bit confused as to why ConcurrentEffect was here when we're not using any of its methods. I see now that sub requires a Concurrent instance which is supplied on creation, so I suppose the subscriber could explicitly require a ConcurrentEffect to indicate concurrency.
| @@ -1 +1 @@ | |||
| sbt.version=1.0.4 | |||
| sbt.version=1.1.6 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutionContextis replaced byTimerEffectis still necessary forunsafeRunAsyncs.Concurrentis necessary forDeferred, which replacesPromise.Effect+Concurrent=ConcurrentEffectMaybe we can whittle this down some more, but this is a minimal update that passes all tests.