Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify constraint descriptor for v_old and root == anchor to indicate inclusive OR #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PlanetMacro
Copy link

@PlanetMacro PlanetMacro commented Feb 26, 2025

In src/circuit.rs#L241, the constraint is currently described as:

"Either v_old = 0, or root = anchor"

However, this phrasing can be read as an exclusive-or (XOR), suggesting that not both conditions can be true at once.

To prevent confusion, the PR rephrased the comment/descriptor to

"v_old = 0, or root = anchor"

so it clearly indicates an inclusive-or rather than an exclusive-or. This will help auditors avoid misreading the condition as prohibiting both v_old == 0 and root == anchor from being true simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant