Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Constraint System #4021

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor Constraint System #4021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions zellij-server/src/panes/tiled_panes/pane_resizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// Brooks's TODOs
// 1) See if `taffy` will simplify this code?
// 2) Refactor stuff so that the stages are clearer and have less technical jargon (eg. spans, discretisations, etc.)
// 3) Make it so that the constraint system (now known as PaneResizer) doesn't operate on the panes themselves, but
// rather receives a list of PaneGeoms tied to pane ids and then sends back a list of those changed geoms to be mutated
// by whoever called it. This would be great because then it'll allow me to recover from whichever errors this system
// might have in whichever place in the code I place it.
use super::stacked_panes::StackedPanes;
use crate::{panes::PaneId, tab::Pane};
use cassowary::{
Expand Down
Loading