Fix Scoped Storage (Android API 30 Requirement) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… storage, which will not be possible for app to access since Android 11
- mv xml/ -> res/xml/ - Use .mp4 - Remove unused intent arg - Remove unused methods - Remove unnecessary FLAG_GRANT_WRITE_URI_PERMISSION
jorgetinoco
reviewed
Nov 17, 2021
| // still need to capture more video clips | ||
| captureVideo(req); | ||
| } | ||
| if (req.results.length() >= req.limit) { |
There was a problem hiding this comment.
not sure if you would need to check for req.results != null && req.results.length....
There was a problem hiding this comment.
I think this is okay since it was this way before; it was just moved.
|
Thanks for the reviews @jorgetinoco and @felixdelacruzt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the same changes/fixes from apache#215, but rebased against the latest upstream
master. I've also addressed some of the open comments in that PR.Ideally that will get merged soon and we can throw out this fork.