Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split compat layer into different source files #809

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

nmoinvaz
Copy link
Member

No description provided.

@nmoinvaz nmoinvaz added 1.2 Related to older version of minizip 1.2 compatibility Backwards compatibility 1.1 Related to older version of minizip 1.1 cleanup Housekeeping tasks labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 46.89146% with 504 lines in your changes missing coverage. Please review.

Project coverage is 61.85%. Comparing base (8950c24) to head (4d2ecb3).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
compat/unzip.c 51.06% 174 Missing and 78 partials ⚠️
compat/zip.c 43.49% 113 Missing and 26 partials ⚠️
compat/ioapi.c 42.42% 79 Missing and 16 partials ⚠️
compat/crypt.h 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #809      +/-   ##
===========================================
- Coverage    62.01%   61.85%   -0.17%     
===========================================
  Files           32       35       +3     
  Lines         9735     9759      +24     
  Branches      2387     2388       +1     
===========================================
- Hits          6037     6036       -1     
- Misses        2392     2417      +25     
  Partials      1306     1306              
Flag Coverage Δ
macos_xcode 55.41% <0.54%> (-0.07%) ⬇️
macos_xcode_libcompression 55.41% <0.54%> (-0.07%) ⬇️
macos_xcode_openssl 55.41% <0.54%> (-0.07%) ⬇️
ubuntu_clang 60.80% <47.67%> (?)
ubuntu_clang_compress_only 46.86% <0.32%> (-0.02%) ⬇️
ubuntu_clang_decompress_only 32.89% <0.54%> (-0.05%) ⬇️
ubuntu_clang_no_bzip2 60.80% <47.67%> (-0.05%) ⬇️
ubuntu_clang_no_encryption 55.61% <47.77%> (-0.05%) ⬇️
ubuntu_clang_no_lzma 60.21% <47.67%> (-0.05%) ⬇️
ubuntu_clang_no_pkcrypt 60.43% <47.67%> (-0.05%) ⬇️
ubuntu_clang_no_winzip_aes 60.31% <47.77%> (-0.05%) ⬇️
ubuntu_clang_no_zlib 54.04% <0.54%> (-0.07%) ⬇️
ubuntu_clang_no_zstd 60.41% <47.67%> (-0.05%) ⬇️
ubuntu_clang_openssl 60.80% <47.67%> (-0.05%) ⬇️
ubuntu_gcc 60.26% <44.60%> (-0.19%) ⬇️
windows_gcc 56.66% <44.24%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz force-pushed the split-compat branch 6 times, most recently from 887d6cc to 66e864d Compare October 30, 2024 21:27
@nmoinvaz nmoinvaz force-pushed the split-compat branch 2 times, most recently from 61e711e to 0ae9ac0 Compare October 30, 2024 21:42
@nmoinvaz nmoinvaz enabled auto-merge (rebase) October 30, 2024 21:44
@nmoinvaz nmoinvaz disabled auto-merge October 30, 2024 22:11
@nmoinvaz nmoinvaz merged commit 7df56f7 into develop Oct 30, 2024
54 of 56 checks passed
@nmoinvaz nmoinvaz deleted the split-compat branch October 30, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.1 Related to older version of minizip 1.1 1.2 Related to older version of minizip 1.2 cleanup Housekeeping tasks compatibility Backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant