Library Catalog (TIND ILS): Enrich item type from Schema.org #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thms-rmb
force-pushed
the
thms-rmb/improve-item-type-detection
branch
from
9180a24 to
dd4ea42
Compare
Records in the TIND platform may include a Schema.org mapping. This mapping often has a `@type` property that is more accurate than what can be obtained purely from the MARC data of the record.
thms-rmb
force-pushed
the
thms-rmb/improve-item-type-detection
branch
from
dd4ea42 to
b7685d0
Compare
AbeJellinek
requested changes
Jan 22, 2025
Fixed
Right, I think some of the tests might even need to be entirely replaced - Caltech Library no longer uses TIND ILS and so the test links never resolve. I might be able to find roughly equivalent tests from other customers, would it be OK to include that in this PR as well? |
Definitely. |
thms-rmb
force-pushed
the
thms-rmb/improve-item-type-detection
branch
from
8dfa1a2 to
cde2876
Compare
|
Tests have been updated |
skairunner
added a commit
to skairunner/zotero-translators
that referenced
this pull request
Jan 29, 2025
- 720 fields are sometimes used e.g. in datasets to describe additional contributors. - Use 720 field as a contributor. - Note that tests will fail until zotero#3409 is merged. This is because the MARC code assumes that all books with no authors that have contributors are actually meant to be editors, which is invalid. However, we have no way of setting items to be not Book without zotero#3409.
|
Thanks! |
skairunner
added a commit
to skairunner/zotero-translators
that referenced
this pull request
Feb 3, 2025
- 720 fields are sometimes used e.g. in datasets to describe additional contributors. - Use 720 field as a contributor. - Note that tests will fail until zotero#3409 is merged. This is because the MARC code assumes that all books with no authors that have contributors are actually meant to be editors, which is invalid. However, we have no way of setting items to be not Book without zotero#3409.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records in the TIND platform may include a Schema.org mapping. This mapping often has a
@typeproperty that is more accurate than what can be obtained purely from the MARC data of the record.The effort of improving the item type matching was attempted before (in #3387), but a different approach was suggested in a comment (at #3387 (comment)):