Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "typing" status #665

Closed
gnprice opened this issue May 13, 2024 · 0 comments · Fixed by #790
Closed

Show "typing" status #665

gnprice opened this issue May 13, 2024 · 0 comments · Fixed by #790
Assignees
@PIG208
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content
Milestone
M3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented May 13, 2024 •
edited
Loading

I.e., half of this feature:
https://zulip.com/help/typing-notifications
along with #666.

In the API, the relevant data appears as events:
https://zulip.com/api/get-events#typing-start
https://zulip.com/api/get-events#typing-stop

In the code, let's organize the data under a class TypingStatus, similar to Unreads or RecentDmConversationsView.

For logic for comparison, see what's in zulip-mobile or Zulip web. The implementation in zulip-mobile isn't great in how it handles expiry, though (in typingActions.js) — in particular we shouldn't need a polling loop. I haven't studied the web implementation.
@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels May 13, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 13, 2024
@gnprice gnprice mentioned this issue May 13, 2024
Closed
@PIG208 PIG208 mentioned this issue Jul 1, 2024
Merged
@PIG208 PIG208 self-assigned this Jul 1, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 5, 2024
@PIG208
msglist: Display typing indicators on typing.
d39c084 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@PIG208 PIG208 mentioned this issue Jul 5, 2024
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 5, 2024
@PIG208
msglist: Display typing indicators on typing.
2b24264 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 5, 2024
@PIG208
msglist: Display typing indicators on typing.
fc9db66 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 5, 2024
@PIG208
msglist: Display typing indicators on typing.
ba78d03 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 5, 2024
@PIG208
msglist: Display typing indicators on typing.
dbdf6e8 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 6, 2024
@PIG208
msglist: Display typing indicators on typing.
b18cfd8 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 8, 2024
@PIG208
msglist: Display typing indicators on typing.
50c994a 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 8, 2024
@PIG208
msglist: Display typing indicators on typing.
2f6790b 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 8, 2024
@PIG208
msglist: Display typing indicators on typing.
cd62fea 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 8, 2024
@PIG208
msglist: Display typing indicators on typing.
617d7a7 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 10, 2024
@PIG208
msglist: Display typing indicators on typing.
d3767d4 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 11, 2024
@PIG208
msglist: Display typing indicators on typing.
9a420c6 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 15, 2024
@PIG208
msglist: Display typing indicators on typing.
1a9d547 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 23, 2024
@PIG208
msglist: Display typing indicators on typing.
14ef196 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 23, 2024
@PIG208
msglist: Display typing indicators on typing.
fd00b9e 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 23, 2024
@PIG208
msglist: Display typing indicators on typing.
3bf08e1 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 26, 2024
@PIG208
msglist: Display typing indicators on typing.
45d9d14 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Display typing indicators on typing.
961c7dc 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 29, 2024
@PIG208
msglist: Display typing indicators on typing.
1a417cc 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Display typing indicators on typing.
d10f229 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Display typing indicators on typing.
2208f61 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jul 30, 2024
@PIG208
msglist: Display typing indicators on typing.
71ef85a 
Because we don't have a Figma design yet, this revision supports a basic
design similar to the web app when there are people typing.

Fixes zulip#665.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@PIG208 PIG208 mentioned this issue Dec 19, 2024
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PIG208 PIG208

Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
M3: Summer 2024
Development

Successfully merging a pull request may close this issue.

msglist: Display typing indicators on typing. PIG208/zulip-flutter
2 participants
@gnprice @PIG208