fix: Clearing previous recorded video if start new one. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkb912002
changed the title
kkb912002
changed the title
lib/commands/record-screen.js
Outdated
| @@ -252,6 +252,9 @@ export async function startRecordingScreen ( | |||
| } | |||
| this.log.debug('Forcing the active screen recording to stop'); | |||
| await this._screenRecorder.stop(true); | |||
| } else if (this._screenRecorder) { | |||
| this.log.debug('Clearing previous record'); | |||
There was a problem hiding this comment.
Clearing the recent screen recording
mykola-mokhnach
approved these changes
Mar 5, 2025
KazuCocoa
approved these changes
Mar 5, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [4.2.1](v4.2.0...v4.2.1) (2025-03-05) ### Bug Fixes * Clearing the recent recorded video if start new one. ([#302](#302)) ([d8c8b87](d8c8b87))
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when recording screen multiple times, only the last recorded file gets deleted, while the previously recorded files all remain in the temporary directory.