feat: respect settings for showing also in overview table #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippMa
requested changes
Mar 20, 2025
...onents/AttributionCountPerSourcePerLicenseTable/AttributionCountPerSourcePerLicenseTable.tsx
Outdated
Show resolved
Hide resolved
...ionCountPerSourcePerLicenseTable/__tests__/AttributionCountPerSourcePerLicenseTable.test.tsx
Outdated
Show resolved
Hide resolved
...ionCountPerSourcePerLicenseTable/__tests__/AttributionCountPerSourcePerLicenseTable.test.tsx
Outdated
Show resolved
Hide resolved
src/Frontend/Components/TableCellWithSorting/TableCellWithSorting.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
only allow one channel to get the full user-settings information from the backend Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Hellgartner
force-pushed
the
feat/toggle-also-statistics-table
branch
from
63855e9 to
fa3605e
Compare
Fixed bug: * User selects one of the switchable columns for ordering * User switches that column off * User clicks on Name Without the fix, the sorting direction for names would not change as expected Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
PhilippMa
requested changes
Mar 20, 2025
| @@ -9,13 +9,19 @@ import upath from 'upath'; | |||
|
|
|||
| import { getIconPath } from './iconHelpers'; | |||
|
|
|||
| const openDevTools = (mainWindow: BrowserWindow) => { | |||
There was a problem hiding this comment.
Did you commit this on purpose?
| orderDirection: | ||
| effectiveOrdering.orderDirection === 'asc' ? 'desc' : 'asc', | ||
| }); | ||
| } else if (ordering.orderedColumn === columnId) { |
There was a problem hiding this comment.
Can we not just go into the first case regardless of whether effectiveOrdering equals ordering?
Comment on lines
+59
to
+71
| describe('Attribution count per source per license table', () => { | ||
| it('shows by default criticality and classification columns', () => { | ||
| renderComponent(<AttributionCountPerSourcePerLicenseTable {...props} />); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Criticality', | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
Is there a way to get rid of the linter warnings that these tests have no assertions? Maybe it's better to move the expect statement out of the function back into the test cases themselves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Also adapt the statistics table based on the configuration for showing classifications and criticality
Context and reason for change
See #2849
How can the changes be tested
Open the statistics popup and toggle the classifications/criticality on and off
Note: Please review the guidelines for contributing to this repository.