feat: respect settings for showing also in overview table #2861
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| // SPDX-FileCopyrightText: Meta Platforms, Inc. and its affiliates | ||
| // SPDX-FileCopyrightText: TNG Technology Consulting GmbH <https://www.tngtech.com> | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { Screen } from '@testing-library/dom/types/screen'; | ||
| import { act, fireEvent, screen } from '@testing-library/react'; | ||
|
|
||
| import { Criticality } from '../../../../shared/shared-types'; | ||
| import { setUserSetting } from '../../../state/actions/user-settings-actions/user-settings-actions'; | ||
| import { renderComponent } from '../../../test-helpers/render'; | ||
| import { LicenseCounts } from '../../../types/types'; | ||
| import { | ||
| AttributionCountPerSourcePerLicenseTable, | ||
| AttributionCountPerSourcePerLicenseTableProps, | ||
| } from '../AttributionCountPerSourcePerLicenseTable'; | ||
|
|
||
| const licenseCounts: LicenseCounts = { | ||
| attributionCountPerSourcePerLicense: { | ||
| licenseA: { | ||
| sourceA: 1, | ||
| sourceB: 3, | ||
| }, | ||
| licenseB: { | ||
| sourceB: 2, | ||
| }, | ||
| }, | ||
| totalAttributionsPerLicense: { | ||
| licenseA: 4, | ||
| licenseB: 2, | ||
| }, | ||
| totalAttributionsPerSource: { | ||
| sourceA: 1, | ||
| sourceB: 5, | ||
| }, | ||
| }; | ||
| const props: AttributionCountPerSourcePerLicenseTableProps = { | ||
| licenseCounts, | ||
| licenseNamesWithCriticality: { | ||
| licenseA: Criticality.High, | ||
| licenseB: Criticality.Medium, | ||
| }, | ||
| licenseNamesWithClassification: { | ||
| licenseA: 2, | ||
| licenseB: 3, | ||
| }, | ||
| }; | ||
|
|
||
| function expectHeaderTextsToEqual( | ||
| screen: Screen, | ||
| expectedHeaderTexts: Array<string>, | ||
| ) { | ||
| const headerTexts = screen | ||
| .getAllByTestId('table-cell-with-sorting') | ||
| .map((node) => node.textContent); | ||
|
|
||
| expect(headerTexts).toEqual(expectedHeaderTexts); | ||
| } | ||
|
|
||
| describe('Attribution count per source per license table', () => { | ||
| it('shows by default criticality and classification columns', () => { | ||
| renderComponent(<AttributionCountPerSourcePerLicenseTable {...props} />); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Criticality', | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
| }); | ||
|
Comment on lines
+59
to
+71
There was a problem hiding this comment. Is there a way to get rid of the linter warnings that these tests have no assertions? Maybe it's better to move the expect statement out of the function back into the test cases themselves? |
||
|
|
||
| it('does not show criticality if disabled', () => { | ||
| renderComponent(<AttributionCountPerSourcePerLicenseTable {...props} />, { | ||
| actions: [setUserSetting({ showCriticality: false })], | ||
| }); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
| }); | ||
|
|
||
| it('does not show classification if disabled', () => { | ||
| renderComponent(<AttributionCountPerSourcePerLicenseTable {...props} />, { | ||
| actions: [setUserSetting({ showClassifications: false })], | ||
| }); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Criticality', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
| }); | ||
|
|
||
| it('switches back to default sorting if the sorted by column is dropped', () => { | ||
| const { store } = renderComponent( | ||
| <AttributionCountPerSourcePerLicenseTable {...props} />, | ||
| ); | ||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Criticality', | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
|
|
||
| fireEvent.click(screen.getByText('Criticality')); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Name', | ||
| 'Criticalitysorted descending', //correct, the sorted, descending is for a11y | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
|
|
||
| act(() => { | ||
| store.dispatch(setUserSetting({ showCriticality: false })); | ||
| }); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted ascending', //correct, the sorted, ascending is for a11y | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
|
|
||
| fireEvent.click(screen.getByText('Name')); | ||
|
|
||
| expectHeaderTextsToEqual(screen, [ | ||
| 'Namesorted descending', //correct, the sorted, descending is for a11y | ||
| 'Classification', | ||
| 'SourceA', | ||
| 'SourceB', | ||
| 'Total', | ||
| ]); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you commit this on purpose?