-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsafe perform io #130
Open
adrianmay
wants to merge
27
commits into
tahoe-lafs:master
Choose a base branch
from
adrianmay:remove-unsafePerformIO
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is JP's #84 which removes most uses of unsafePerformIO and changes the Haskell interface to IO, plus:
fec_init
that's also free of unsafePerformIOThis PR (or some variation of it) is essential because
unsafePerformIO
is extremely unsafe. It may stand alone, but I recommend that it be immediately followed by #131 that completely removesfec_init
and the Haskell wrapper'sinitialize
, initialising the tables with verbatim values in C, and bumping the major version again.Bumping the major version twice in quick succession strikes me as less bad than any other option. I wouldn't expect the intermediate version to get used but its existence mitigates any risk in the second PR.