Remove unsafe perform io

ChangeLog.md

@@ -1,5 +1,9 @@
 # Changelog for fec
 
+## 1.0 0 (2025-03-17)
+
+* Haskell wrapper returns IO throughout to avoid unsafePerformIO
+
 ## 0.2.0 (2023-10-06)
 
 * Application code must now execute the `Codec.FEC.initialize` action at least

benchmark-zfec/Main.hs

@@ -2,7 +2,7 @@ module Main where
 
 import Codec.FEC (FECParams (paramK, paramN), decode, encode, fec, initialize)
 import Control.Monad (replicateM)
-import Criterion.Main (Benchmark, bench, bgroup, defaultMain, env, nf)
+import Criterion.Main (Benchmark, bench, bgroup, defaultMain, env, nfAppIO)
 import Data.Bifunctor (bimap)
 import qualified Data.ByteString as B
 import Data.List (unfoldr)
@@ -13,15 +13,11 @@ main =
     defaultMain
         -- Run against some somewhat arbitrarily chosen configurations.  Notably,
         -- though, 94/100 matches the numbers recorded in the readme.
-        [ env (setupFEC 2 3) makeFECBenchmarks
-        , env (setupFEC 16 31) makeFECBenchmarks
-        , env (setupFEC 94 100) makeFECBenchmarks
+        [ env (fec 2 3) makeFECBenchmarks
+        , env (fec 16 31) makeFECBenchmarks
+        , env (fec 94 100) makeFECBenchmarks
         ]
   where
-    setupFEC :: Int -> Int -> IO FECParams
-    setupFEC k n = do
-        initialize
-        pure (fec k n)
 
     makeFECBenchmarks = fecGroup [10 ^ 6]
 
@@ -53,20 +49,20 @@ main =
             -- result is serialize use all of the bytes (eg, to write them to a
             -- file or send them over the network) so they will certainly all be
             -- used.
-            nf (uncurry encode) (params, blocks)
+            nfAppIO (uncurry encode) (params, blocks)
 
     benchmarkPrimaryDecode params blocks =
         bench ("decode [0..] blockSize=" <> showWithUnit (B.length $ head blocks)) $
             -- normal form here for the same reason as in benchmarkEncode.
             -- assign block numbers to use only primary blocks
-            nf (uncurry decode) (params, (zip [0 ..] blocks))
+            nfAppIO (uncurry decode) (params, (zip [0 ..] blocks))
 
     benchmarkSecondaryDecode params blocks =
         bench ("decode [" <> show n <> "..] blockSize=" <> showWithUnit (B.length $ head blocks)) $
             -- normal form here for the same reason as in benchmarkEncode.
             -- assign block numbers to use as many non-primary blocks as
             -- possible
-            nf (uncurry decode) (params, (zip [n ..] blocks))
+            nfAppIO (uncurry decode) (params, (zip [n ..] blocks))
       where
         n = paramN params - paramK params
 

fec.cabal

@@ -1,6 +1,6 @@
 cabal-version:      3.0
 name:               fec
-version:            0.2.0
+version:            1.0.0
 license:            GPL-2.0-or-later
 license-file:       README.rst
 author:             Adam Langley <agl@imperialviolet.org>
@@ -31,10 +31,11 @@ extra-doc-files:    ChangeLog.md
 
 library
   build-depends:
-    , base        >=4.9  && <5
-    , bytestring  >=0.10 && <0.13
-    , deepseq     >=1.4  && <1.6
-    , extra       >=1.7  && <1.8
+    , base <5
+    , bytestring <0.13
+    , deepseq <1.7
+    , extra <2
+    , global-lock <1
 
   exposed-modules:    Codec.FEC
   default-language:   Haskell2010
@@ -49,11 +50,11 @@ executable benchmark-zfec
   main-is:          Main.hs
   ghc-options:      -threaded
   build-depends:
-    , base        >=4.9  && <5
-    , bytestring  >=0.10 && <0.13
-    , criterion   >=1.1  && <1.7
+    , base <5
+    , bytestring <0.13
+    , criterion <1.7
     , fec
-    , random      >=1.1  && <1.3
+    , random <2
 
   hs-source-dirs:   benchmark-zfec
   default-language: Haskell2010
@@ -65,13 +66,13 @@ test-suite tests
   hs-source-dirs:   haskell/test
   ghc-options:      -Wall -threaded -rtsopts -with-rtsopts=-N
   build-depends:
-    , base                  >=4.9  && <5
-    , bytestring            >=0.10 && <0.13
-    , data-serializer       >=0.3  && <0.4
+    , base <5                
+    , bytestring <0.13
+    , data-serializer <1
     , fec
-    , hspec                 >=2.7  && <2.12
-    , QuickCheck            >=2.14 && <2.15
-    , quickcheck-instances  >=0.3  && <0.4
-    , random                >=1.1  && <1.3
+    , hspec <3
+    , QuickCheck <2.16
+    , quickcheck-instances <1
+    , random <2
 
   default-language: Haskell2010