Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and build with newer Pythons #75

Closed
wants to merge 19 commits into from
Closed

Test and build with newer Pythons #75

wants to merge 19 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented Dec 18, 2022 •
edited
Loading

See #74. These are the changes:

  • Add Python 3.11 and PyPy 3.9 to both test and build matrices.
  • Update cibuildwheel version (because of the above), and use cibuildwheel action rather than the Python package (because it avoids some of the boilerplate).
  • Use the same OSes in test and build steps, and be more explicit about them (not just -latest).
  • Build macOS arm64 and universal2 wheels as well (because why not), but without testing them, because cibuildwheels docs says that they can't be tested on Intel. (Results are on TestPyPI.)
  • Update the soon-to-be deprecated actions.
  • Cache Python packages when possible.

@sajith sajith temporarily deployed to release December 18, 2022 15:19 — with GitHub Actions Inactive
@sajith sajith temporarily deployed to release December 18, 2022 15:40 — with GitHub Actions Inactive
@sajith
Update pypi-publish action
ccbdb08 
Because of this warning from the action:

> You are using "pypa/gh-action-pypi-publish@master". The "master"
> branch of this project has been sunset and will not receive any
> updates, not even security bug fixes. Please, make sure to use a
> supported version. If you want to pin to v1 major version, use
> "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous,
> you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1"
> instead. A more general recommendation is to pin to exact tags or
> commit shas.
@sajith
Update download-artifact action
f46ab08 
Because of this warning:

> Node.js 12 actions are deprecated. For more information see:
> https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please
> update the following actions to use Node.js 16:
> actions/download-artifact@v2
@sajith
Use a newer Ubuntu
bdaa209 
Because of this warning:

> The ubuntu-18.04 environment is deprecated, consider switching to
> ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more
> details see
> actions/runner-images#6002
@sajith sajith temporarily deployed to release December 18, 2022 17:46 — with GitHub Actions Inactive
@sajith sajith temporarily deployed to release December 18, 2022 18:43 — with GitHub Actions Inactive
@sajith sajith linked an issue Dec 18, 2022 that may be closed by this pull request
add Python 3.11 support #74
Closed
@sajith sajith temporarily deployed to release December 18, 2022 18:57 — with GitHub Actions Inactive
@sajith sajith temporarily deployed to release December 19, 2022 13:38 — with GitHub Actions Inactive
@sajith sajith changed the title Add newer Pythons to test matrix Test and build with newer Pythons Dec 19, 2022
@sajith sajith temporarily deployed to release December 19, 2022 14:29 — with GitHub Actions Inactive
@sajith sajith marked this pull request as ready for review December 19, 2022 14:34
@sajith sajith requested a review from a team December 19, 2022 14:34
@sajith sajith requested a review from exarkun December 19, 2022 14:35
@exarkun
Copy link
Member

exarkun commented Dec 19, 2022

See #74. These are the changes:

* Add Python 3.11 and PyPy 3.9 to both test and build matrices.

* Update cibuildwheel version (because of the above), and use cibuildwheel action rather than the Python package (because it avoids some of the boilerplate).

* Use the same OSes in test and build steps, and be more explicit about them (not just `-latest`).

* Build macOS arm64 and universal2 wheels as well (because why not), but without testing them, because cibuildwheels docs [says](https://cibuildwheel.readthedocs.io/en/stable/options/) that they can't be tested on Intel. ([Results](https://test.pypi.org/project/zfec/1.5.7.2.post0.dev21/#files) are on TestPyPI.)

* Update the soon-to-be deprecated actions.

* Cache Python packages when possible.

Thanks. Do you mind splitting this into a few different PRs? At a glance, it seems like three makes sense:

  1. CI housekeeping - action updates & caching improvements
  2. Build universal wheels
  3. Add more Python versions to the build/test matrices

How does that sound?

@sajith
Copy link
Member Author

sajith commented Dec 19, 2022

Thanks. Do you mind splitting this into a few different PRs? At a glance, it seems like three makes sense:

1. CI housekeeping - action updates & caching improvements

2. Build universal wheels

3. Add more Python versions to the build/test matrices

How does that sound?

That sounds reasonable but I will have to watch the CI spin across three separate PRs again and that is not... fun. >_<

Will get on that when I have some time.

This was referenced Dec 19, 2022
Closed
Closed
Merged
@sajith
Copy link
Member Author

sajith commented Dec 19, 2022

Following up with issues #76, #77, and PR #78.

@sajith sajith closed this Dec 19, 2022
@sajith sajith deleted the 74.py11-test-build branch December 19, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun Awaiting requested review from exarkun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Python 3.11 support
2 participants
@sajith @exarkun