-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions workflows #78
Conversation
And use the same OSes in both workflows
v2 is deprecated
v2 is deprecated
Because of this warning from the action: > You are using "pypa/gh-action-pypi-publish@master". The "master" > branch of this project has been sunset and will not receive any > updates, not even security bug fixes. Please, make sure to use a > supported version. If you want to pin to v1 major version, use > "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, > you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" > instead. A more general recommendation is to pin to exact tags or > commit shas.
Because of this warning: > Node.js 12 actions are deprecated. For more information see: > https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please > update the following actions to use Node.js 16: > actions/download-artifact@v2
Avoid some boilerplate
Better to be supported util 2027-10 than until 2023-06-27!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seems reasonable. One inline comment. Please address and merge.
There's an error from TestPyPI upload step: https://github.com/tahoe-lafs/zfec/actions/runs/3751489909/jobs/6372612263
That must be because of the previous uploads from this PR? I'll just ignore that for now. |
Summary of changes:
pip install
-ing cibuildwheel. There's less boilerplate this way.Addresses issue #76, supercedes PR #75. Will follow up with PRs that address #74 and #77 once if/when this gets merged.