Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflows #78

Merged
merged 13 commits into from
Dec 21, 2022
Merged

Update GitHub Actions workflows #78

merged 13 commits into from
Dec 21, 2022

Conversation

sajith
Copy link
Member

@sajith sajith commented Dec 19, 2022

Summary of changes:

  • Update actions that cause deprecation warnings.
  • Use pip caches when possible.
  • Update OSes. Use same OSes in both test and build workflows, and be explicit about which OS we use.
  • Use cibuildwheel action instead of pip install-ing cibuildwheel. There's less boilerplate this way.

Addresses issue #76, supercedes PR #75. Will follow up with PRs that address #74 and #77 once if/when this gets merged.

And use the same OSes in both workflows
v2 is deprecated
Because of this warning from the action:

> You are using "pypa/gh-action-pypi-publish@master". The "master"
> branch of this project has been sunset and will not receive any
> updates, not even security bug fixes. Please, make sure to use a
> supported version. If you want to pin to v1 major version, use
> "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous,
> you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1"
> instead. A more general recommendation is to pin to exact tags or
> commit shas.
Because of this warning:

> Node.js 12 actions are deprecated. For more information see:
> https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please
> update the following actions to use Node.js 16:
> actions/download-artifact@v2
Avoid some boilerplate
@sajith sajith linked an issue Dec 19, 2022 that may be closed by this pull request
@sajith sajith marked this pull request as ready for review December 19, 2022 22:32
@sajith sajith requested review from exarkun and a team December 19, 2022 22:32
Better to be supported util 2027-10 than until 2023-06-27!
@sajith sajith temporarily deployed to release December 19, 2022 22:55 — with GitHub Actions Inactive
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems reasonable. One inline comment. Please address and merge.

@sajith
Copy link
Member Author

sajith commented Dec 21, 2022

There's an error from TestPyPI upload step:

https://github.com/tahoe-lafs/zfec/actions/runs/3751489909/jobs/6372612263

Uploading distributions to https://test.pypi.org/legacy/
Uploading zfec-1.5.7.2.post0.dev15-cp310-cp310-macosx_10_9_x86_64.whl
25l
0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/80.3 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 80.3/80.3 kB • 00:00 • 73.4 MB/s
25hWARNING Error during upload. Retry with the --verbose option for more details.
ERROR HTTPError: 400 Bad Request from https://test.pypi.org/legacy/
File already exists. See https://test.pypi.org/help/#file-name-reuse
for more information.

That must be because of the previous uploads from this PR? I'll just ignore that for now.

@sajith sajith merged commit b5b0644 into master Dec 21, 2022
@sajith sajith deleted the 76.update-ga-workflows branch December 21, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GA workflow actions
2 participants