native: use channel.meta to store custom channel config on API #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il/integrate-custom-meta
This avoids issues where we have a ChannelMetadata and want to pass it to a function that previously required a (narrower) ChannelMetadataSchemaV1 argument.
We don't have any UI that allows configuring a custom channel on creation, so no need to keep this around.
…it scry to include meta in channel
davidisaaclee
changed the title
|
This branch currently has this bug:
so ship B does not get the customizations when they join (and I don't think they will resolve the customizations until someone makes a change to the meta) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes TLON-3290
Updates custom channel API code to use new
metafield on channel instead of putting a structured string indescription.channel.metais only inchannelsapp and notgroups(nor DMs), I removed a number of places where we were populating content cfg from group's channel's descriptions or DM's descriptionChannelMetadata,ContentRenderer) – these are safe, since the backend treats all of the data inchannel.metaas an opaque string (and there are no prod clients that have already stored data in one of these types)groups-ui/v5/initwas added to includechannel.metain the init payload; we use this to seed the channel content config when loading client data for the first time.useContactName, but at least one layer is more explicit)