Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: use channel.meta to store custom channel config on API #4371

Draft
wants to merge 27 commits into
base: release-channels-updates
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1c5a177
Merge remote-tracking branch 'origin/release-channels-updates' into d…
davidisaaclee Jan 21, 2025
b85f972
Add configuration dict to ContentRenderer
davidisaaclee Jan 21, 2025
9f0aad1
Use ChannelMetadata instead of specific ChannelMetadataSchemaV1
davidisaaclee Jan 21, 2025
6147499
Remove content config from createChannel
davidisaaclee Jan 21, 2025
814aaa8
Set content config based on legacy channel types on creation
davidisaaclee Jan 21, 2025
39a22b3
Remove unused import
davidisaaclee Jan 21, 2025
c0a4792
Send channel meta updates over API
davidisaaclee Jan 21, 2025
4288810
Remove content config from group DMs
davidisaaclee Jan 21, 2025
79d2686
Include channelId in client metadata update event
davidisaaclee Jan 22, 2025
e55c93f
Update local channel cfg on event
davidisaaclee Jan 22, 2025
e462038
Disable receiving content configuration over groups APIs
davidisaaclee Jan 23, 2025
8a82f25
Prevent %groups overwriting contentConfiguration with missing field
davidisaaclee Jan 23, 2025
32e8240
channels: rename wrong %channel-action-2 to %channel-action-1
mikolajpp Jan 24, 2025
aae9859
channels: replace wrong %channel-action-2 mark. groups-ui: fix /v5/in…
mikolajpp Jan 24, 2025
771c1a2
Fix mistyped parameter name showAuthor -> showAuthors
davidisaaclee Jan 24, 2025
faa4c57
Point updateChannelMeta to correct mark
davidisaaclee Jan 24, 2025
f6fc3ba
Remove unused StructuredChannelDescription type
davidisaaclee Jan 24, 2025
a2ef550
Use groups-ui /v5/init
davidisaaclee Jan 24, 2025
1563478
channels: add missing fields
arthyn Jan 25, 2025
d3817b9
Make Channel.meta nullable (legacy channels do not have a meta)
davidisaaclee Jan 27, 2025
39faec7
Use correct ChannelFromServer type in GroupsInit response
davidisaaclee Jan 27, 2025
957d379
Add meta to ChannelInit payload, and use to set channel metas on init
davidisaaclee Jan 27, 2025
38f42eb
Avoid forced unwrap (after seeing it cause a crash)
davidisaaclee Jan 27, 2025
dbd627d
Make custom channels flag visible to dev clients
davidisaaclee Jan 27, 2025
5549799
Merge remote-tracking branch 'origin/release-channels-updates' into d…
davidisaaclee Jan 29, 2025
3be36f2
Merge remote-tracking branch 'origin/develop' into dil/integrate-cust…
davidisaaclee Jan 29, 2025
a203235
Merge branch 'release-channels-updates' into dil/integrate-custom-meta
arthyn Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent %groups overwriting contentConfiguration with missing field
davidisaaclee committed Jan 27, 2025
commit 8a82f25e5a30187039e49a85262d9916b40183d5
10 changes: 8 additions & 2 deletions packages/shared/src/db/queries.ts
Original file line number Diff line number Diff line change
@@ -491,8 +491,14 @@ export const insertGroups = createWriteQuery(
$channels.description,
$channels.addedToGroupAt,
$channels.type,
$channels.isPendingChannel,
$channels.contentConfiguration
$channels.isPendingChannel

// > Why not update `contentConfiguration` here?
// Because this codepath is coming from %groups, which does not
// know about a channel's `meta` - so we never want to
// overwrite the config with the missing config from %groups.
//
// $channels.contentConfiguration
),
});