Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run-policy to cosmic-swingset #3582

Closed
warner opened this issue Aug 2, 2021 · 2 comments · Fixed by #3651
Closed

add run-policy to cosmic-swingset #3582

warner opened this issue Aug 2, 2021 · 2 comments · Fixed by #3651
Assignees
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request

Comments

@warner
Copy link
Member

warner commented Aug 2, 2021

What is the Problem Being Solved?

Once #3459 is done, we hope to have an idea of what sort of computron limit to apply to each block. Once #3580 has landed, we'll have a way to apply it. At that point, the task will be to update cosmic-swingset:

  • create a computronCounter run-policy object at the beginning of each cycle
  • use c.run(policy) instead of the current for() loop that calls c.step() some maximum number of times

For the solo machine, we can either leave the existing mechanism in place (drain the queue each time), or add a wallClockWaiter to limit the work-until-commit duration to something like 2-5 seconds.

Test Plan

I think this will have to be tested manually, with a load generator cranked high enough to cause the run-queue to remain full for a while.

@warner warner added enhancement New feature or request cosmic-swingset package: cosmic-swingset labels Aug 2, 2021
@warner warner added this to the Testnet: Metering Phase milestone Aug 2, 2021
@dckc
Copy link
Member

dckc commented Aug 3, 2021

Once #3459 is done, we hope to have an idea of what sort of computron limit to apply to each block.

Examination of one busy block suggests an 8-10M computron limit.

@dckc
Copy link
Member

dckc commented Aug 9, 2021

@warner you mentioned making the threshold configurable via governance. Is that required?

p.s. no, not required, from discussion with @michaelfig.

dckc added a commit that referenced this issue Aug 11, 2021
…3651)

fixes #3582

* refine vat creation cost in block threshold
* open-code computronCounter
* first block computes the whole bootstrap

Co-authored-by: Michael FIG <mfig@agoric.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants