Add pipewire passthrough #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
2 times, most recently
from
d1291b2 to
8ff53f1
Compare
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
8ff53f1 to
ae7d696
Compare
|
@WhatAmISupposedToPutHere Given that the dependencies on libkrun and libkrunfw have been merged, I guess this one is now ready for review (after a rebase)? |
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
ae7d696 to
0fee63f
Compare
WhatAmISupposedToPutHere
requested review from
slp,
teohhanhui,
alyssarosenzweig and
asahilina
as code owners
|
I think we should merge this one and do a new release. @WhatAmISupposedToPutHere could you please rebase your changes? |
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
0fee63f to
67c9e32
Compare
teohhanhui
reviewed
Feb 11, 2025
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
67c9e32 to
9e6600b
Compare
teohhanhui
reviewed
Feb 11, 2025
teohhanhui
reviewed
Feb 11, 2025
teohhanhui
reviewed
Feb 11, 2025
teohhanhui
reviewed
Feb 11, 2025
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
9e6600b to
39e72cb
Compare
slp
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM. @teohhanhui anything else you would like to see addressed?
|
@slp The logic is above my pay grade, so all I could offer was nits 😂 So, LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds enough pipewire passthrough for cameras and simple audio playback (and maybe some other things, haven't tested those). Due to most apps that use pipewire for cameras getting the pipewire socket from the xdg portal, we need to ship customized wireplumber rules that will assign proper permissions (it is a slightly modified version of a script that already ships with WP).
Draft, since it needs containers/libkrun#248 and containers/libkrunfw#82