Add pipewire cross domain channel type. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatAmISupposedToPutHere
requested review from
mtjhrc,
slp and
tylerfanelli
as code owners
|
Clippy errors appear to be unrelated to the code actually changed by this PR. |
|
Please update |
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
a739dfd to
1cb7306
Compare
This adds a pipewire channel type, increases the maximum number of fds that can be transferred in a single message, and adds support for sharing eventfds between the guest and host. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
pipewire
branch
from
1cb7306 to
9d210c1
Compare
slp
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the already existing wayland/x11 cross domain channel to also work for sharing pipewire between host and guest. The necessary changes are eventfd support (inspired by how wayland pipes are handled), a few fixes to sharing shm buffers, and a new protocol version that supports more fds per message (pw can sometimes send more than 4).