-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooCommerce Install: Update styles #60229
Conversation
Brings styles closer to the figma
Somehow I broke the transfer step styles with this. So I'll look at that next. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~126 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~5030 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~9448 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
// Height of 22 ensures combobox input matches height of text controls | ||
height: 22px; | ||
// Height of 18 ensures combobox input matches height of text controls. | ||
height: 18px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably still want to go ahead with this change here but FYI a fix might come from upstream at some point WordPress/gutenberg#38020
Maybe this is me being picky but the label colors, I think don't match the ones in the design |
That should be a matter of which color scheme you use, I don't believe I'm currently using the default one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see what @Rolilink is talking about regarding the font colors. The Figma looks slightly darker, but the hex values appear to be the same. I think it could be a minor difference in font or possibly the field borders making the font color appear lighter. But I think this PR is good to ship. 👍
Brings styles closer to the figma file.
Changes proposed in this Pull Request
Testing instructions
After