ComboBox: fix reset button's height
#38020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Package] Components
ciampo
reviewed
Jan 24, 2022
Comment on lines
265
to
267
| parameters: { | ||
| knobs: { disable: false }, | ||
| }, |
There was a problem hiding this comment.
The knobs addon is deprecated and we're in the process of converting the examples to the new controls approach.
Would you mind refactoring this Storybook example? Here's a couple of references:
There was a problem hiding this comment.
Thanks for the links, will take a look later this week.
lsl
force-pushed
the
update/combo-box-reset-button
branch
2 times, most recently
from
87a7151 to
0c94627
Compare
|
@ciampo Updated to remove knobs usage + added changelog. |
ciampo
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Thank you @lsl for working on this! Code changes LGTM, and the Storybook example is configured correctly with the Controls.
I believe this PR needs to be rebased before merging — while doing so, could you also move the CHANGELOG entry under a category (e.g. ### Bug fix)? Thank you!
lsl
force-pushed
the
update/combo-box-reset-button
branch
from
0c94627 to
72fa268
Compare
|
@ciampo, done! Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the height of the reset button icon so that it doesn't expand the textbox height that contains it.
This expanded height was noticed when we placed it next to a text input we expected would have a matching height (example, it's off by 2px).
How has this been tested?
Manually checking in storybook docs
Screenshots
Before
allowReset-before.mp4
After
allowReset-after.mp4
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).