chore(docs): Extend stable documentation versions to build to cover multiple beta.n releases (noir-lang/noir#7685)

chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684)
chore: add trailing slash to link on docs homepage (noir-lang/noir#7682)
fix: allow referring to comptime locals at runtime (noir-lang/noir#7681)
chore: easier way to test monormophization errors (noir-lang/noir#7679)
chore(docs): update bb commands to match the new version (noir-lang/noir#7677)
chore: update yarn version to 4.5.2 (noir-lang/noir#7678)
chore: migrate to use new flat eslint config file (noir-lang/noir#7676)
chore: bump JS dependencies (noir-lang/noir#7669)
chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675)
chore: bump node to v22.18.3 (noir-lang/noir#7668)
chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664)
fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659)
chore: bump external pinned commits (noir-lang/noir#7667)
chore: fixing timeouts (noir-lang/noir#7666)
chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665)
chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661)
chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638)
chore: remove some unused HIR code (noir-lang/noir#7643)
chore: update examples to use UltraHonk (noir-lang/noir#7653)
fix: allow method call after block, if and match (noir-lang/noir#7655)
chore: address recurring typo in docs (noir-lang/noir#7656)
fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)

Author: AztecBot

.noir-sync-commit

@@ -1 +1 @@
-70007925eb4e57a1e0482ae329862afce98c1119
+99830073ec96932948bbdec7a269f025e0bac136

noir/noir-repo/.eslintrc.js

@@ -7,10 +7,10 @@ runs:
     - uses: actions/setup-node@v4
       id: node
       with:
-        node-version: 18.19.0
+        node-version: 20.18.3
         cache: 'yarn'
         cache-dependency-path: 'yarn.lock'
-    
+
     - name: Install
       run: yarn --immutable
       shell: bash

noir/noir-repo/.github/actions/setup/action.yml

@@ -44,7 +44,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.0
+          node-version: 20.18.3
           cache: 'yarn'
           cache-dependency-path: 'yarn.lock'
 

noir/noir-repo/.github/workflows/release.yml

@@ -438,7 +438,7 @@ jobs:
         run: |
           # Note the lack of spaces between package names.
           PACKAGES_TO_BUILD="@noir-lang/types,@noir-lang/noir_js"
-          yarn workspaces foreach -vtp --from "{$PACKAGES_TO_BUILD}" run build
+          yarn workspaces foreach -Wvtp --from "{$PACKAGES_TO_BUILD}" run build
 
       - name: Run `integration-tests`
         working-directory: ./compiler/integration-tests
@@ -483,7 +483,7 @@ jobs:
         run: |
           # Note the lack of spaces between package names.
           PACKAGES_TO_BUILD="@noir-lang/types,@noir-lang/noir_js"
-          yarn workspaces foreach -vtp --from "{$PACKAGES_TO_BUILD}" run build
+          yarn workspaces foreach -Wvtp --from "{$PACKAGES_TO_BUILD}" run build
 
       - name: Run `integration-tests`
         working-directory: ./compiler/integration-tests

noir/noir-repo/.github/workflows/test-js-packages.yml

@@ -0,0 +1 @@
+20.18.3

noir/noir-repo/.nvmrc

@@ -1,15 +1,11 @@
+compressionLevel: mixed
+
+enableGlobalCache: false
+
 logFilters:
   - code: YN0013
     level: discard
 
 nodeLinker: node-modules
 
-plugins:
-  - path: .yarn/plugins/@yarnpkg/plugin-typescript.cjs
-    spec: "@yarnpkg/plugin-typescript"
-  - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
-    spec: "@yarnpkg/plugin-workspace-tools"
-  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
-    spec: "@yarnpkg/plugin-interactive-tools"
-
-yarnPath: .yarn/releases/yarn-3.6.3.cjs
+yarnPath: .yarn/releases/yarn-4.5.2.cjs

noir/noir-repo/.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

@@ -26,12 +26,12 @@
     "package.json"
   ],
   "sideEffects": false,
-  "packageManager": "yarn@3.5.1",
+  "packageManager": "yarn@4.5.2",
   "scripts": {
     "build": "bash ./build.sh",
     "test": "env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",
     "test:browser": "web-test-runner",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0",
+    "lint": "NODE_NO_WARNINGS=1 eslint . --max-warnings 0",
     "publish": "echo 📡 publishing `$npm_package_name` && yarn npm publish",
     "nightly:version": "jq --arg new_version \"-$(git rev-parse --short HEAD)$1\" '.version = .version + $new_version' package.json > package-tmp.json && mv package-tmp.json package.json",
     "clean": "chmod u+w web nodejs || true && rm -rf web nodejs"
@@ -42,11 +42,11 @@
     "@web/test-runner": "^0.18.1",
     "@web/test-runner-playwright": "^0.11.0",
     "chai": "^4.4.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "mocha": "^10.2.0",
-    "prettier": "3.2.5",
+    "eslint": "^9.22.0",
+    "eslint-plugin-prettier": "^5.2.3",
+    "mocha": "^11.1.0",
+    "prettier": "3.5.3",
     "ts-node": "^10.9.1",
-    "typescript": "^5.4.2"
+    "typescript": "^5.8.2"
   }
 }

noir/noir-repo/.yarn/plugins/@yarnpkg/plugin-typescript.cjs

@@ -8,7 +8,7 @@ it('returns the correct build info', () => {
 
   try {
     revision = process.env.GIT_COMMIT || child_process.execSync('git rev-parse HEAD').toString().trim();
-  } catch (error) {
+  } catch (_error) {
     console.log('Failed to get revision, skipping test.');
     return;
   }

noir/noir-repo/.yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs

@@ -1,10 +1,10 @@
-import { esbuildPlugin } from "@web/dev-server-esbuild";
-import { playwrightLauncher } from "@web/test-runner-playwright";
+import { esbuildPlugin } from '@web/dev-server-esbuild';
+import { playwrightLauncher } from '@web/test-runner-playwright';
 
 export default {
   browsers: [
-    playwrightLauncher({ product: "chromium" }),
-    playwrightLauncher({ product: "webkit" }),
+    playwrightLauncher({ product: 'chromium' }),
+    playwrightLauncher({ product: 'webkit' }),
     // Firefox requires 40s to perform a Pedersen hash so we recommend using either
     // a Chromium- or Webkit-based browser
     // playwrightLauncher({ product: "firefox" }),
@@ -14,11 +14,11 @@ export default {
       ts: true,
     }),
   ],
-  files: ["test/browser/**/*.test.ts"],
+  files: ['test/browser/**/*.test.ts'],
   nodeResolve: true,
   testFramework: {
     config: {
-      ui: "bdd",
+      ui: 'bdd',
       timeout: 40000,
     },
   },

noir/noir-repo/.yarn/releases/yarn-3.6.3.cjs

@@ -10,23 +10,23 @@
     "test:browser": "web-test-runner",
     "test:integration:browser": "web-test-runner test/browser/**/*.test.ts",
     "test:integration:browser:watch": "web-test-runner test/browser/**/*.test.ts --watch",
-    "lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore  --max-warnings 0"
+    "lint": "NODE_NO_WARNINGS=1 eslint . --max-warnings 0"
   },
   "dependencies": {
     "@aztec/bb.js": "portal:../../../../barretenberg/ts",
     "@noir-lang/noir_js": "workspace:*",
     "@noir-lang/noir_wasm": "workspace:*",
-    "@nomicfoundation/hardhat-chai-matchers": "^2.0.0",
-    "@nomicfoundation/hardhat-ethers": "^3.0.0",
+    "@nomicfoundation/hardhat-chai-matchers": "^2.0.8",
+    "@nomicfoundation/hardhat-ethers": "^3.0.8",
     "@web/dev-server-esbuild": "^0.3.6",
     "@web/dev-server-import-maps": "^0.2.0",
     "@web/test-runner": "^0.18.1",
     "@web/test-runner-playwright": "^0.11.0",
-    "eslint": "^8.57.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "ethers": "^6.7.1",
-    "hardhat": "^2.22.6",
-    "prettier": "3.2.5",
+    "eslint": "^9.22.0",
+    "eslint-plugin-prettier": "^5.2.3",
+    "ethers": "^6.13.5",
+    "hardhat": "^2.22.19",
+    "prettier": "3.5.3",
     "smol-toml": "^1.1.2",
     "toml": "^3.0.0",
     "tslog": "^4.9.2"

noir/noir-repo/.yarn/releases/yarn-4.5.2.cjs

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { expect } from '@esm-bundle/chai';
 import { TEST_LOG_LEVEL } from '../environment.js';
 import { Logger } from 'tslog';

noir/noir-repo/.yarnrc.yml

@@ -7,7 +7,7 @@ import { importMapsPlugin } from '@web/dev-server-import-maps';
 
 let reporter = summaryReporter();
 const debugPlugins = [];
-// eslint-disable-next-line no-undef
+
 if (process.env.CI !== 'true' || process.env.RUNNER_DEBUG === '1') {
   reporter = defaultReporter();
   debugPlugins.push({
@@ -26,12 +26,14 @@ export default {
     // playwrightLauncher({ product: "webkit" }),
     // playwrightLauncher({ product: "firefox" }),
   ],
-  middleware: [async (ctx, next) => {
-    if (ctx.url.endsWith('.wasm.gz')) {
-      ctx.url = ctx.url.replace('/', "/node_modules/@aztec/bb.js/dest/browser/");
-    }
-    await next();
-  }],
+  middleware: [
+    async (ctx, next) => {
+      if (ctx.url.endsWith('.wasm.gz')) {
+        ctx.url = ctx.url.replace('/', '/node_modules/@aztec/bb.js/dest/browser/');
+      }
+      await next();
+    },
+  ],
   plugins: [
     esbuildPlugin({
       ts: true,
@@ -55,7 +57,7 @@ export default {
       ui: 'bdd',
     },
   },
-  // eslint-disable-next-line no-undef
+
   rootDir: fileURLToPath(new URL('./../..', import.meta.url)),
   testsFinishTimeout: 60 * 20e3, // 20 minutes
   reporters: [reporter],

noir/noir-repo/acvm-repo/acvm_js/.eslintignore

@@ -17,7 +17,9 @@ use crate::{
         expr::{HirExpression, HirIdent, HirMethodReference, ImplKind, TraitMethod},
         stmt::HirPattern,
     },
-    node_interner::{DefinitionId, DefinitionKind, ExprId, FuncId, GlobalId, TraitImplKind},
+    node_interner::{
+        DefinitionId, DefinitionInfo, DefinitionKind, ExprId, FuncId, GlobalId, TraitImplKind,
+    },
 };
 
 use super::{Elaborator, ResolverMeta, path_resolution::PathResolutionItem};
@@ -542,8 +544,10 @@ impl Elaborator<'_> {
 
         let type_generics = item.map(|item| self.resolve_item_turbofish(item)).unwrap_or_default();
 
-        let definition_kind =
-            self.interner.try_definition(definition_id).map(|definition| definition.kind.clone());
+        let definition = self.interner.try_definition(definition_id);
+        let is_comptime_local = !self.in_comptime_context()
+            && definition.is_some_and(DefinitionInfo::is_comptime_local);
+        let definition_kind = definition.as_ref().map(|definition| definition.kind.clone());
 
         let mut bindings = TypeBindings::new();
 
@@ -574,7 +578,23 @@ impl Elaborator<'_> {
         let typ = self.type_check_variable_with_bindings(expr, id, generics, bindings);
         self.interner.push_expr_type(id, typ.clone());
 
-        (id, typ)
+        // If this variable it a comptime local variable, use its current value as the final expression
+        if is_comptime_local {
+            let mut interpreter = self.setup_interpreter();
+            let value = interpreter.evaluate(id);
+            // If the value is an error it means the variable already had an error, so don't report it here again
+            // (the error will make no sense, it will say that a non-comptime variable was referenced at runtime
+            // but that's not true)
+            if value.is_ok() {
+                let (id, typ) = self.inline_comptime_value(value, location);
+                self.debug_comptime(location, |interner| id.to_display_ast(interner).kind);
+                (id, typ)
+            } else {
+                (id, typ)
+            }
+        } else {
+            (id, typ)
+        }
     }
 
     /// Solve any generics that are part of the path before the function, for example:

noir/noir-repo/acvm-repo/acvm_js/.eslintrc.js

@@ -1,5 +1,8 @@
 #![cfg(test)]
-use crate::tests::get_program;
+use crate::{
+    elaborator::UnstableFeature,
+    tests::{check_monomorphization_error_using_features, get_program},
+};
 
 use super::{ast::Program, errors::MonomorphizationError, monomorphize};
 
@@ -29,6 +32,8 @@ fn bounded_recursive_type_errors() {
     let src = "
         fn main() {
             let _tree: Tree<Tree<Tree<()>>> = Tree::Branch(
+                                              ^^^^^^^^^^^^ Type `Tree<Tree<()>>` is recursive
+                                              ~~~~~~~~~~~~ All types in Noir must have a known size at compile-time
                 Tree::Branch(Tree::Leaf, Tree::Leaf),
                 Tree::Branch(Tree::Leaf, Tree::Leaf),
             );
@@ -37,10 +42,10 @@ fn bounded_recursive_type_errors() {
         enum Tree<T> {
             Branch(T, T),
             Leaf,
-        }";
-
-    let error = get_monomorphized(src).unwrap_err();
-    assert!(matches!(error, MonomorphizationError::RecursiveType { .. }));
+        }
+        ";
+    let features = vec![UnstableFeature::Enums];
+    check_monomorphization_error_using_features(src, &features);
 }
 
 #[test]
@@ -63,17 +68,19 @@ fn recursive_type_with_alias_errors() {
     let src = "
         fn main() {
             let _tree: Opt<OptAlias<()>> = Opt::Some(OptAlias::None);
+                                           ^^^^^^^^^ Type `Opt<()>` is recursive
+                                           ~~~~~~~~~ All types in Noir must have a known size at compile-time
         }
 
         type OptAlias<T> = Opt<T>;
 
         enum Opt<T> {
             Some(T),
             None,
-        }";
-
-    let error = get_monomorphized(src).unwrap_err();
-    assert!(matches!(error, MonomorphizationError::RecursiveType { .. }));
+        }
+        ";
+    let features = vec![UnstableFeature::Enums];
+    check_monomorphization_error_using_features(src, &features);
 }
 
 #[test]
@@ -85,16 +92,18 @@ fn mutually_recursive_types_error() {
 
         enum Even {
             Zero,
+            ^^^^ Type `Odd` is recursive
+            ~~~~ All types in Noir must have a known size at compile-time
             Succ(Odd),
         }
 
         enum Odd {
             One,
             Succ(Even),
-        }";
-
-    let error = get_monomorphized(src).unwrap_err();
-    assert!(matches!(error, MonomorphizationError::RecursiveType { .. }));
+        }
+        ";
+    let features = vec![UnstableFeature::Enums];
+    check_monomorphization_error_using_features(src, &features);
 }
 
 #[test]

noir/noir-repo/acvm-repo/acvm_js/package.json

@@ -573,6 +573,10 @@ impl DefinitionInfo {
     pub fn is_global(&self) -> bool {
         self.kind.is_global()
     }
+
+    pub fn is_comptime_local(&self) -> bool {
+        self.comptime && matches!(self.kind, DefinitionKind::Local(..))
+    }
 }
 
 #[derive(Debug, Clone, Eq, PartialEq)]