Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove some unused HIR code #7643

Merged
merged 2 commits into from
Mar 11, 2025
Merged

chore: remove some unused HIR code #7643

merged 2 commits into from
Mar 11, 2025

Conversation

asterite
Copy link
Collaborator

Description

Problem

I noticed this while working on #7613

Summary

Another thing I noticed is that HirExpression::Unquote is created here but I don't know if that should be HirExpression::Quoted (if so, HirExpression::Unquote could also be removed)

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team March 10, 2025 14:54
michaeljklein
michaeljklein approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Perhaps @jfecher knows why these became unused?

@asterite asterite added this pull request to the merge queue Mar 11, 2025
@asterite
Copy link
Collaborator Author

I'll merge this as it's harmless. When Jake comes back we can ask him and revert if needed.

Merged via the queue into master with commit bdbdb63 Mar 11, 2025
105 checks passed
@asterite asterite deleted the ab/remove-unused-hir branch March 11, 2025 15:16
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 12, 2025
@AztecBot
[1 changes] chore!: make ResolverError::UnnecessaryPub a hard error (…
983538c 
…noir-lang/noir#7664)

fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659)
chore: bump external pinned commits (noir-lang/noir#7667)
chore: fixing timeouts (noir-lang/noir#7666)
chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665)
chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661)
chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638)
chore: remove some unused HIR code (noir-lang/noir#7643)
chore: update examples to use UltraHonk (noir-lang/noir#7653)
fix: allow method call after block, if and match (noir-lang/noir#7655)
chore: address recurring typo in docs (noir-lang/noir#7656)
fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
@AztecBot AztecBot mentioned this pull request Mar 12, 2025
Open
TomAFrench added a commit that referenced this pull request Mar 12, 2025
@TomAFrench
Merge branch 'master' into arv/resolve_callstacks
d839aa7 
* master:
  chore: update yarn version to 4.5.2 (#7678)
  chore: migrate to use new flat eslint config file (#7676)
  chore: bump JS dependencies (#7669)
  chore: bump wasm-pack to 0.13.1 (#7675)
  chore: bump node to v22.18.3 (#7668)
  chore!: make `ResolverError::UnnecessaryPub` a hard error (#7664)
  fix: correctly format let followed by comment before unsafe (#7659)
  chore: bump external pinned commits (#7667)
  chore: fixing timeouts (#7666)
  chore(ssa): Do not print entire functions in underconstrained values check trace (#7665)
  chore(ci): Exclude enum tests from Brillig reports (#7661)
  chore: add regression tests for PR #7570 from lambda interpreter test (#7638)
  chore: remove some unused HIR code (#7643)
  chore: update examples to use UltraHonk (#7653)
  fix: allow method call after block, if and match (#7655)
  chore: address recurring typo in docs (#7656)
  fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (#7644)
  chore: bump external pinned commits (#7640)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 13, 2025
@AztecBot
[1 changes] chore(docs): Extend stable documentation versions to buil…
da73c0b 
…d to cover multiple `beta.n` releases (noir-lang/noir#7685)

chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684)
chore: add trailing slash to link on docs homepage (noir-lang/noir#7682)
fix: allow referring to comptime locals at runtime (noir-lang/noir#7681)
chore: easier way to test monormophization errors (noir-lang/noir#7679)
chore(docs): update bb commands to match the new version (noir-lang/noir#7677)
chore: update yarn version to 4.5.2 (noir-lang/noir#7678)
chore: migrate to use new flat eslint config file (noir-lang/noir#7676)
chore: bump JS dependencies (noir-lang/noir#7669)
chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675)
chore: bump node to v22.18.3 (noir-lang/noir#7668)
chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664)
fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659)
chore: bump external pinned commits (noir-lang/noir#7667)
chore: fixing timeouts (noir-lang/noir#7666)
chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665)
chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661)
chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638)
chore: remove some unused HIR code (noir-lang/noir#7643)
chore: update examples to use UltraHonk (noir-lang/noir#7653)
fix: allow method call after block, if and match (noir-lang/noir#7655)
chore: address recurring typo in docs (noir-lang/noir#7656)
fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 13, 2025
@AztecBot
chore(docs): Extend stable documentation versions to build to cover m…
6433ddf 
…ultiple `beta.n` releases (noir-lang/noir#7685)

chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684)
chore: add trailing slash to link on docs homepage (noir-lang/noir#7682)
fix: allow referring to comptime locals at runtime (noir-lang/noir#7681)
chore: easier way to test monormophization errors (noir-lang/noir#7679)
chore(docs): update bb commands to match the new version (noir-lang/noir#7677)
chore: update yarn version to 4.5.2 (noir-lang/noir#7678)
chore: migrate to use new flat eslint config file (noir-lang/noir#7676)
chore: bump JS dependencies (noir-lang/noir#7669)
chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675)
chore: bump node to v22.18.3 (noir-lang/noir#7668)
chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664)
fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659)
chore: bump external pinned commits (noir-lang/noir#7667)
chore: fixing timeouts (noir-lang/noir#7666)
chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665)
chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661)
chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638)
chore: remove some unused HIR code (noir-lang/noir#7643)
chore: update examples to use UltraHonk (noir-lang/noir#7653)
fix: allow method call after block, if and match (noir-lang/noir#7655)
chore: address recurring typo in docs (noir-lang/noir#7656)
fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljklein michaeljklein michaeljklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asterite @michaeljklein