-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: easier way to test monormophization errors #7679
Conversation
08ed57f
to
48ee202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 79364d6 | Previous: d1338c1 | Ratio |
---|---|---|---|
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
53 s |
43 s |
1.23 |
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib |
11 s |
9 s |
1.22 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See nit r.e. error printing method
That way it's easier to see what are the errors without having to copy the source code, paste it to a file and run the compiler to see the actual errors.
…d to cover multiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
…ultiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
Description
Problem
No issue, just something I wanted to do for completeness.
Summary
Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.