Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pubInputsOffset to Solidity Honk VK #1281

Open
lucasxia01 opened this issue Mar 4, 2025 · 0 comments
Open

Add pubInputsOffset to Solidity Honk VK #1281

lucasxia01 opened this issue Mar 4, 2025 · 0 comments

Comments

@lucasxia01
Copy link
Contributor

Currently just using 1 everywhere instead, but should be fixed or removed entirely from honk vk.
@lucasxia01 lucasxia01 mentioned this issue Mar 4, 2025
Merged
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 12, 2025
@lucasxia01 @saleel
feat: Make public inputs the start of the UH and MH proof (#12266)
b6294ad 
Closes AztecProtocol/barretenberg#1089.

Removes the circuitSize, numPublicInputs, and pubInputsOffset metadata
from the proof. The result is that the public inputs are at the
beginning of the proof.

Followup work includes:
- Medium: making these metadata actual witnesses in the recursive VK
(AztecProtocol/barretenberg#983).
- Small: fixing verify_honk_proof acir test inputs
(AztecProtocol/barretenberg#1279).
- Small: cleaning up or removing the proof surgeon.
- Medium: Further structuring the proof/public inputs output as Cody
suggests in AztecProtocol/barretenberg#1089 to
split out the accumulators in the pub inputs.
- Small Adding pubInputsOffset to the Honk Solidity VK
(AztecProtocol/barretenberg#1281).

---------

Co-authored-by: saleel <saleel@saleel.xyz>
AztecBot pushed a commit that referenced this issue Mar 13, 2025
@lucasxia01 @saleel @AztecBot
feat: Make public inputs the start of the UH and MH proof (#12266)
e4a1265 
Closes #1089.

Removes the circuitSize, numPublicInputs, and pubInputsOffset metadata
from the proof. The result is that the public inputs are at the
beginning of the proof.

Followup work includes:
- Medium: making these metadata actual witnesses in the recursive VK
(#983).
- Small: fixing verify_honk_proof acir test inputs
(#1279).
- Small: cleaning up or removing the proof surgeon.
- Medium: Further structuring the proof/public inputs output as Cody
suggests in #1089 to
split out the accumulators in the pub inputs.
- Small Adding pubInputsOffset to the Honk Solidity VK
(#1281).

---------

Co-authored-by: saleel <saleel@saleel.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucasxia01