Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should circuit_size, etc.. be witnesses in Recursive VerificationKey? #983

Closed
lucasxia01 opened this issue May 16, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#12459
Closed

Should circuit_size, etc.. be witnesses in Recursive VerificationKey? #983

lucasxia01 opened this issue May 16, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#12459
Assignees
@lucasxia01

Comments

@lucasxia01
Copy link
Contributor

Currently, they are just native values because the proof already contains identical information that will be turned into witnesses. But, this deserves more thinking.
@lucasxia01 lucasxia01 self-assigned this Feb 28, 2025
This was referenced Mar 4, 2025
Merged
Merged
AztecBot pushed a commit that referenced this issue Mar 6, 2025
@lucasxia01 @AztecBot
fix: make vk metadata actual witnesses (#12459)
da6136a 
Closes #983.

Makes the vk metadata witnesses instead of native types. I think only
circuit_size actually needs to be a witness, but its fine to make them
all witnesses. Still a lot of security concerns around this area since
there's missing constraints with these witnesses.
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 12, 2025
@lucasxia01 @saleel
feat: Make public inputs the start of the UH and MH proof (#12266)
b6294ad 
Closes AztecProtocol/barretenberg#1089.

Removes the circuitSize, numPublicInputs, and pubInputsOffset metadata
from the proof. The result is that the public inputs are at the
beginning of the proof.

Followup work includes:
- Medium: making these metadata actual witnesses in the recursive VK
(AztecProtocol/barretenberg#983).
- Small: fixing verify_honk_proof acir test inputs
(AztecProtocol/barretenberg#1279).
- Small: cleaning up or removing the proof surgeon.
- Medium: Further structuring the proof/public inputs output as Cody
suggests in AztecProtocol/barretenberg#1089 to
split out the accumulators in the pub inputs.
- Small Adding pubInputsOffset to the Honk Solidity VK
(AztecProtocol/barretenberg#1281).

---------

Co-authored-by: saleel <saleel@saleel.xyz>
AztecBot pushed a commit that referenced this issue Mar 13, 2025
@lucasxia01 @saleel @AztecBot
feat: Make public inputs the start of the UH and MH proof (#12266)
e4a1265 
Closes #1089.

Removes the circuitSize, numPublicInputs, and pubInputsOffset metadata
from the proof. The result is that the public inputs are at the
beginning of the proof.

Followup work includes:
- Medium: making these metadata actual witnesses in the recursive VK
(#983).
- Small: fixing verify_honk_proof acir test inputs
(#1279).
- Small: cleaning up or removing the proof surgeon.
- Medium: Further structuring the proof/public inputs output as Cody
suggests in #1089 to
split out the accumulators in the pub inputs.
- Small Adding pubInputsOffset to the Honk Solidity VK
(#1281).

---------

Co-authored-by: saleel <saleel@saleel.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make vk metadata actual witnesses AztecProtocol/aztec-packages
1 participant
@lucasxia01