Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fluid Router GUI crash #6173

Open
wants to merge 2 commits into
base: 1.21.1
Choose a base branch
from
Open

Conversation

leagris
Copy link

@leagris leagris commented Mar 4, 2025

Fix #6172 by adding check for Empty fluid in setFluidInSlot
Fix Fluid Router not working on remote world (Multiplayer)

Address issue BluSunrize#6172 by adding check for Empty fluid in `setFluidInSlot`
@leagris
Copy link
Author

leagris commented Mar 4, 2025

With this fix, the Fluid Router GUI no longer crashes with an Illegal State Exception.

I was finally able to configure it for my automated potion of Strength setup, feeding into my refinery with the goal of producing cetane-boosted diesel.

https://imgur.com/gallery/immersive-engineering-fixed-fluid-router-gui-crash-KLUogXg

screenshot
screenshot
screenshot

@leagris
Copy link
Author

leagris commented Mar 5, 2025

Noticed that the Fluid Router settings are not working at all on multiplayer. Nothing happens.
This needs more fixes

@leagris leagris marked this pull request as ready for review March 5, 2025 22:34
@@ -86,7 +90,8 @@ public void receiveMessageFromScreen(CompoundTag message)
int side = message.getInt("filter_side");
int slot = message.getInt("filter_slot");
FluidStack newFilter = FluidStack.parseOptional(
Minecraft.getInstance().level.registryAccess(),
((MinecraftServer)LogicalSidedProvider.WORKQUEUE.get(LogicalSide.SERVER)).overworld()
.registryAccess(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely there is a cleaner way to do this? Maybe via the player?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluid router GUI IllegalStateException: Cannot encode empty FluidStack
2 participants