Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail Trucks Ignore Lane Arrows #338

Merged
merged 1 commit into from
May 31, 2019
Merged

Mail Trucks Ignore Lane Arrows #338

merged 1 commit into from
May 31, 2019

Conversation

VictorPhilipp
Copy link
Collaborator

@VictorPhilipp VictorPhilipp commented May 27, 2019 •
edited by FireController1847
Loading

Post trucks implement their own StartPathFind method. Because TMPE did not override it, path-finding got ExtVehicleType.None which in turn led to m_isLaneArrowObeyingEntity=false.

Fixes #307

@VictorPhilipp VictorPhilipp added this to the 10.21 milestone May 27, 2019
@VictorPhilipp VictorPhilipp requested a review from krzychu124 May 27, 2019 15:30
@originalfoo originalfoo self-requested a review May 27, 2019 23:44
@originalfoo originalfoo added enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability labels May 27, 2019
@FireController1847 FireController1847 changed the title Fixed #307: Mail trucks ignore lane arrows Mail Trucks Ignore Lane Arrows May 28, 2019
krzychu124
krzychu124 approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍

@VictorPhilipp VictorPhilipp merged commit 14687d6 into master May 31, 2019
@originalfoo originalfoo deleted the 307-mail-trucks-ignore-arrows branch March 29, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzychu124 krzychu124 krzychu124 approved these changes

@originalfoo originalfoo Awaiting requested review from originalfoo

Assignees
No one assigned
Labels
enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
10.21
Development

Successfully merging this pull request may close these issues.

Mail trucks ignoring lane arrows
3 participants
@VictorPhilipp @krzychu124 @originalfoo