[IAST] Skip failing tests #6455

robertpi · 2024-12-17T17:05:15Z

Summary of changes

Skip two tests that now fail on master. They fail because the endpoint in the test app they use was removed.

This wasn't spotted in the PR because they are only run on master.

A larger refactoring to fix this is in progress.

andrewlock · 2024-12-17T17:15:57Z

tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/AspNetCore2IastTests.cs

@@ -573,6 +573,8 @@ await VerifyHelper.VerifySpans(spansFiltered, settings)
    [Trait("RunOnWindows", "True")]
    public async Task TestIastStoredXssRequest()
    {
+        throw new SkipException("End point missing due to changes in Samples.Security.AspNetCore2 - refactoring in progess to restore");


This is the same as doing this, right?

[SkippableFact(Skip = "End point missing due to changes in Samples.Security.AspNetCore2 - refactoring in progess to restore")]

We always want to skip, right? These tests only run on .NET Core 2.1?

Yes, definitely only run on Core 2.1, we always want to skip because it can't work anywhere. I wasn't aware of the other way to skip test, I'll use that next time.

Should be re-enabled soon anyway.

datadog-ddstaging · 2024-12-17T17:26:52Z

Datadog Report

Branch report: robert/asm/skip-dotnet-20-tests-that-cant-work
Commit report: f26ecc5
Test service: dd-trace-dotnet

❌ 3 Failed (0 Known Flaky), 464051 Passed, 2859 Skipped, 20h 9m 59.94s Total Time

❌ Failed Tests (3)

StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark
StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark
StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark

andrewlock · 2024-12-17T18:06:51Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (982ms)  : 957, 1008
     .   : milestone, 982,
    master - mean (980ms)  : 952, 1008
     .   : milestone, 980,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (676ms)  : 663, 690
     .   : milestone, 676,
    master - mean (679ms)  : 663, 695
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (632ms)  : 615, 649
     .   : milestone, 632,
    master - mean (633ms)  : 616, 650
     .   : milestone, 633,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (1,105ms)  : 1077, 1132
     .   : milestone, 1105,
    master - mean (1,098ms)  : 1072, 1123
     .   : milestone, 1098,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (867ms)  : 842, 892
     .   : milestone, 867,
    master - mean (868ms)  : 840, 895
     .   : milestone, 868,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6455) - mean (267ms)  : 262, 272
     .   : milestone, 267,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6455) - mean (844ms)  : 805, 884
     .   : milestone, 844,
    master - mean (853ms)  : 824, 881
     .   : milestone, 853,

andrewlock · 2024-12-18T01:47:31Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6455) (11.244M)   : 0, 11243701
    master (11.163M)   : 0, 11163379
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6455) (7.312M)   : 0, 7312276
    master (7.265M)   : 0, 7264817
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.670M)   : 0, 7670252

    section Manual
    master (11.116M)   : 0, 11115719

    section Manual + Automatic
    This PR (6455) (6.752M)   : 0, 6751641
    master (6.789M)   : 0, 6789402

    section DD_TRACE_ENABLED=0
    master (10.411M)   : 0, 10410923

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6455) (9.635M)   : 0, 9635072
    master (9.330M)   : 0, 9329645
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6455) (6.487M)   : 0, 6486904
    master (6.258M)   : 0, 6257542

    section Trace stats
    master (6.725M)   : 0, 6724804

    section Manual
    master (9.564M)   : 0, 9564271

    section Manual + Automatic
    This PR (6455) (5.971M)   : 0, 5970998
    master (5.828M)   : 0, 5828361

    section DD_TRACE_ENABLED=0
    master (8.501M)   : 0, 8500849

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6455) (10.210M)   : 0, 10210091
    master (9.811M)   : 0, 9810785
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6455) (6.299M)   : 0, 6299034
    master (6.389M)   : 0, 6389247
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.930M)   : 0, 6930451

    section Manual
    master (9.742M)   : 0, 9741749

    section Manual + Automatic
    This PR (6455) (5.790M)   : 0, 5789682
    master (5.896M)   : 0, 5896103

    section DD_TRACE_ENABLED=0
    master (9.127M)   : 0, 9127235

andrewlock · 2024-12-18T06:27:05Z

Benchmarks Report for tracer 🐌

Benchmarks for #6455 compared to master:

1 benchmarks are slower, with geometric mean 1.155
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.83μs	44.4ns	314ns	0.0157	0.00392	0	5.62 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	50.4ns	267ns	0.0196	0.0098	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	61.5ns	238ns	1.05	0.318	0.0898	6.22 KB
#6455	`StartStopWithChild`	net6.0	8μs	45.4ns	304ns	0.0168	0.0084	0	5.61 KB
#6455	`StartStopWithChild`	netcoreapp3.1	10.1μs	57.2ns	396ns	0.0198	0.00494	0	5.8 KB
#6455	`StartStopWithChild`	net472	16.6μs	46.4ns	180ns	1.04	0.325	0.0975	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	498μs	473ns	1.83μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	203ns	734ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	849μs	390ns	1.51μs	0.428	3.3 KB
#6455	`WriteAndFlushEnrichedTraces`	net6.0	478μs	308ns	1.19μs	0	2.7 KB
#6455	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	664μs	878ns	3.17μs	0	2.7 KB
#6455	`WriteAndFlushEnrichedTraces`	net472	848μs	719ns	2.78μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	156μs	1.15μs	11.2μs	0.149	14.47 KB
master	`SendRequest`	netcoreapp3.1	177μs	1.32μs	13μs	0.176	17.27 KB
master	`SendRequest`	net472	0.00295ns	0.00128ns	0.00496ns	0	0 b
#6455	`SendRequest`	net6.0	156μs	1E+03ns	9.95μs	0.148	14.47 KB
#6455	`SendRequest`	netcoreapp3.1	181μs	1.19μs	11.6μs	0.162	17.27 KB
#6455	`SendRequest`	net472	0.00285ns	0.001ns	0.00389ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	554μs	3.13μs	22.1μs	0.53	0	0	41.51 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	651μs	2.87μs	10.3μs	0.342	0	0	41.8 KB
master	`WriteAndFlushEnrichedTraces`	net472	841μs	2.86μs	11.1μs	8.28	2.48	0.414	53.29 KB
#6455	`WriteAndFlushEnrichedTraces`	net6.0	615μs	4.11μs	40.9μs	0.581	0	0	41.6 KB
#6455	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	697μs	3.65μs	17.1μs	0.374	0	0	41.86 KB
#6455	`WriteAndFlushEnrichedTraces`	net472	831μs	2.86μs	11.1μs	8.39	2.52	0.419	53.34 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.35μs	1.76ns	6.82ns	0.0147	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.34ns	5ns	0.0136	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.03μs	2.89ns	10.8ns	0.156	0.00101	987 B
#6455	`ExecuteNonQuery`	net6.0	1.21μs	1.68ns	6.51ns	0.0141	0	1.02 KB
#6455	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.52ns	5.87ns	0.0133	0	1.02 KB
#6455	`ExecuteNonQuery`	net472	2.04μs	1.91ns	7.4ns	0.157	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.67ns	2.51ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	1.36ns	5.25ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.53μs	1.95ns	7.56ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.962ns	3.6ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.72μs	0.503ns	1.88ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.63μs	2.41ns	9.35ns	0.166	1.05 KB
#6455	`CallElasticsearch`	net6.0	1.24μs	0.592ns	2.21ns	0.0138	976 B
#6455	`CallElasticsearch`	netcoreapp3.1	1.56μs	2.04ns	7.64ns	0.0131	976 B
#6455	`CallElasticsearch`	net472	2.47μs	2.54ns	9.51ns	0.157	995 B
#6455	`CallElasticsearchAsync`	net6.0	1.27μs	3.96ns	15.3ns	0.0133	952 B
#6455	`CallElasticsearchAsync`	netcoreapp3.1	1.74μs	0.758ns	2.83ns	0.0131	1.02 KB
#6455	`CallElasticsearchAsync`	net472	2.6μs	1.49ns	5.37ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.39μs	0.689ns	2.58ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.57μs	0.982ns	3.8ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.84μs	2.47ns	9.56ns	0.145	915 B
#6455	`ExecuteAsync`	net6.0	1.26μs	0.3ns	1.04ns	0.0137	952 B
#6455	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.608ns	2.27ns	0.0123	952 B
#6455	`ExecuteAsync`	net472	1.84μs	0.479ns	1.86ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.39μs	1.45ns	5.42ns	0.0312	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.37μs	2.64ns	10.2ns	0.0375	2.85 KB
master	`SendAsync`	net472	7.35μs	2.04ns	7.63ns	0.495	3.12 KB
#6455	`SendAsync`	net6.0	4.43μs	1.96ns	7.32ns	0.0311	2.31 KB
#6455	`SendAsync`	netcoreapp3.1	5.34μs	2.48ns	9.27ns	0.0375	2.85 KB
#6455	`SendAsync`	net472	7.42μs	2.65ns	10.3ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	1.96ns	7.32ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	1.08ns	4.17ns	0.0215	1.64 KB
master	`EnrichedLog`	net472	2.65μs	1.25ns	4.83ns	0.25	1.57 KB
#6455	`EnrichedLog`	net6.0	1.51μs	7.69ns	35.2ns	0.0227	1.64 KB
#6455	`EnrichedLog`	netcoreapp3.1	2.23μs	1.16ns	4.33ns	0.0223	1.64 KB
#6455	`EnrichedLog`	net472	2.74μs	2.24ns	8.66ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	108ns	388ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	174ns	675ns	0.06	0	4.28 KB
master	`EnrichedLog`	net472	152μs	102ns	396ns	0.687	0.229	4.46 KB
#6455	`EnrichedLog`	net6.0	117μs	158ns	592ns	0	0	4.28 KB
#6455	`EnrichedLog`	netcoreapp3.1	122μs	288ns	1.12μs	0	0	4.28 KB
#6455	`EnrichedLog`	net472	151μs	307ns	1.19μs	0.686	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.05μs	0.989ns	3.7ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.27μs	1.9ns	7.1ns	0.0299	2.2 KB
master	`EnrichedLog`	net472	5.05μs	0.657ns	2.27ns	0.32	2.02 KB
#6455	`EnrichedLog`	net6.0	2.79μs	1.11ns	4.3ns	0.0308	2.2 KB
#6455	`EnrichedLog`	netcoreapp3.1	4.09μs	1.69ns	6.53ns	0.0289	2.2 KB
#6455	`EnrichedLog`	net472	4.95μs	1.09ns	4.22ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.41μs	0.943ns	3.65ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	1.33ns	5.16ns	0.0149	1.14 KB
master	`SendReceive`	net472	2.15μs	0.902ns	3.38ns	0.183	1.16 KB
#6455	`SendReceive`	net6.0	1.49μs	1.18ns	4.57ns	0.0164	1.14 KB
#6455	`SendReceive`	netcoreapp3.1	1.85μs	0.81ns	3.03ns	0.0149	1.14 KB
#6455	`SendReceive`	net472	2.19μs	3.58ns	13.9ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.77μs	0.827ns	3.2ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.99μs	1.04ns	4.03ns	0.022	1.65 KB
master	`EnrichedLog`	net472	4.46μs	6.54ns	25.3ns	0.324	2.04 KB
#6455	`EnrichedLog`	net6.0	2.66μs	1.13ns	4.39ns	0.0226	1.6 KB
#6455	`EnrichedLog`	netcoreapp3.1	3.89μs	4ns	15.5ns	0.0215	1.65 KB
#6455	`EnrichedLog`	net472	4.37μs	4.27ns	16.5ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6455

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.155	407.64	470.66

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	408ns	0.185ns	0.716ns	0.00801	576 B
master	`StartFinishSpan`	netcoreapp3.1	571ns	0.368ns	1.38ns	0.0077	576 B
master	`StartFinishSpan`	net472	715ns	0.553ns	2.14ns	0.0918	578 B
master	`StartFinishScope`	net6.0	487ns	0.264ns	0.989ns	0.00973	696 B
master	`StartFinishScope`	netcoreapp3.1	732ns	0.406ns	1.57ns	0.00926	696 B
master	`StartFinishScope`	net472	901ns	0.409ns	1.58ns	0.104	658 B
#6455	`StartFinishSpan`	net6.0	471ns	0.287ns	1.11ns	0.00803	576 B
#6455	`StartFinishSpan`	netcoreapp3.1	560ns	0.472ns	1.83ns	0.00764	576 B
#6455	`StartFinishSpan`	net472	665ns	0.607ns	2.35ns	0.0917	578 B
#6455	`StartFinishScope`	net6.0	480ns	0.57ns	2.21ns	0.00983	696 B
#6455	`StartFinishScope`	netcoreapp3.1	728ns	0.513ns	1.99ns	0.00945	696 B
#6455	`StartFinishScope`	net472	920ns	0.527ns	2.04ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	644ns	0.585ns	2.27ns	0.00991	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	970ns	1.02ns	3.96ns	0.00928	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.687ns	2.66ns	0.104	658 B
#6455	`RunOnMethodBegin`	net6.0	590ns	0.303ns	1.13ns	0.00977	696 B
#6455	`RunOnMethodBegin`	netcoreapp3.1	975ns	0.849ns	3.29ns	0.00923	696 B
#6455	`RunOnMethodBegin`	net472	1.11μs	0.466ns	1.74ns	0.104	658 B

Skip failing tests

f26ecc5

robertpi requested a review from a team as a code owner December 17, 2024 17:05

github-actions bot added the area:tests unit tests, integration tests label Dec 17, 2024

daniel-romano-DD approved these changes Dec 17, 2024

View reviewed changes

NachoEchevarria approved these changes Dec 17, 2024

View reviewed changes

andrewlock approved these changes Dec 17, 2024

View reviewed changes

roisinlh mentioned this pull request Dec 17, 2024

Data Streams Monitoring support in Kinesis #6428

Merged

robertpi merged commit aaaf963 into master Dec 19, 2024
102 of 104 checks passed

robertpi deleted the robert/asm/skip-dotnet-20-tests-that-cant-work branch December 19, 2024 09:52

github-actions bot added this to the vNext-v3 milestone Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IAST] Skip failing tests #6455

[IAST] Skip failing tests #6455

robertpi commented Dec 17, 2024

andrewlock Dec 17, 2024

robertpi Dec 19, 2024

robertpi Dec 19, 2024

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading

andrewlock commented Dec 17, 2024

andrewlock commented Dec 18, 2024

andrewlock commented Dec 18, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6455

Raw results

Raw results

[IAST] Skip failing tests #6455

[IAST] Skip failing tests #6455

Conversation

robertpi commented Dec 17, 2024

Summary of changes

andrewlock Dec 17, 2024

Choose a reason for hiding this comment

robertpi Dec 19, 2024

Choose a reason for hiding this comment

robertpi Dec 19, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Dec 17, 2024 • edited Loading

Datadog Report

❌ Failed Tests (3)

andrewlock commented Dec 17, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 18, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 18, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6455

Raw results

Raw results

datadog-ddstaging bot commented Dec 17, 2024 •

edited

Loading