Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAST] Skip failing tests #6455

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[IAST] Skip failing tests #6455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/AspNetCore2IastTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,8 @@ await VerifyHelper.VerifySpans(spansFiltered, settings)
[Trait("RunOnWindows", "True")]
public async Task TestIastStoredXssRequest()
{
throw new SkipException("End point missing due to changes in Samples.Security.AspNetCore2 - refactoring in progess to restore");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as doing this, right?

[SkippableFact(Skip = "End point missing due to changes in Samples.Security.AspNetCore2 - refactoring in progess to restore")]

We always want to skip, right? These tests only run on .NET Core 2.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely only run on Core 2.1, we always want to skip because it can't work anywhere. I wasn't aware of the other way to skip test, I'll use that next time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be re-enabled soon anyway.


var filename = "Iast.StoredXss.AspNetCore2." + (IastEnabled ? "IastEnabled" : "IastDisabled");
if (RedactionEnabled is true) { filename += ".RedactionEnabled"; }
var url = "/Iast/StoredXss";
Expand All @@ -596,6 +598,8 @@ await VerifyHelper.VerifySpans(spansFiltered, settings)
[Trait("RunOnWindows", "True")]
public async Task TestIastStoredXssEscapedRequest()
{
throw new SkipException("End point missing due to changes in Samples.Security.AspNetCore2 - refactoring in progess to restore");

var filename = "Iast.StoredXssEscaped.AspNetCore2." + (IastEnabled ? "IastEnabled" : "IastDisabled");
var url = "/Iast/StoredXssEscaped";
IncludeAllHttpSpans = true;
Expand Down
Loading