Fix pinned locals parsing + bump dotnet version for protobuf and eShopOnWeb exploration tests #6475
+164
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
andrewlock
approved these changes
Dec 20, 2024
ah, right, I was just thinking we could wait for a green CI and be good to go, but it looks like they only run for the debugger |
Datadog ReportBranch report: ✅ 0 Failed, 250761 Passed, 2849 Skipped, 32h 19m 25.13s Total Time New Flaky Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (69ms) : 65, 72
. : milestone, 69,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (975ms) : 948, 1002
. : milestone, 975,
master - mean (979ms) : 948, 1010
. : milestone, 979,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (107ms) : 105, 110
. : milestone, 107,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (674ms) : 659, 689
. : milestone, 674,
master - mean (678ms) : 664, 693
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (91ms) : 88, 93
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (626ms) : 610, 641
. : milestone, 626,
master - mean (635ms) : 620, 649
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (193ms) : 189, 198
. : milestone, 193,
master - mean (194ms) : 190, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (1,099ms) : 1070, 1127
. : milestone, 1099,
master - mean (1,103ms) : 1066, 1140
. : milestone, 1103,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (278ms) : 273, 282
. : milestone, 278,
master - mean (277ms) : 274, 281
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (867ms) : 841, 894
. : milestone, 867,
master - mean (870ms) : 843, 897
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6475) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (267ms) : 263, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6475) - mean (848ms) : 805, 890
. : milestone, 848,
master - mean (852ms) : 825, 878
. : milestone, 852,
|
vandonr
commented
Dec 20, 2024
| @@ -599,20 +599,20 @@ public static ExplorationTestDescription GetExplorationTestDescription(Explorati | |||
| { | |||
| Name = ExplorationTestName.eShopOnWeb, | |||
| GitRepositoryUrl = "https://github.com/dotnet-architecture/eShopOnWeb.git", | |||
| GitRepositoryTag = "netcore2.1", | |||
| GitRepositoryTag = "main", | |||
There was a problem hiding this comment.
I know we want to target a specific tag/version to make sure there is no variability in the CI from distant changes, but here the repo has been archived since 6+ months, so I think we're pretty safe pulling main, it shouldn't change any time soon.
There was a problem hiding this comment.
Even so, it probably makes sense to specify the specific commit?
Suggested change
| GitRepositoryTag = "main", | |
| GitRepositoryTag = "2414014bfa0f4d2021b5bc9061429a98d232f440", |
There was a problem hiding this comment.
thanks, I didn't know we could specify a commit hash here
There was a problem hiding this comment.
actually we can't, this breaks the command used for cloning. Also, it's not even a feature that's readily available with git, it depends on server side config (see https://stackoverflow.com/a/3489576/787883).
I implemented it using a second command to git reset --hard to a provided sha.
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6475) (11.139M) : 0, 11139488
master (11.166M) : 0, 11165619
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6475) (7.282M) : 0, 7282383
master (7.232M) : 0, 7232435
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.555M) : 0, 7555239
section Manual
master (11.218M) : 0, 11218357
section Manual + Automatic
This PR (6475) (6.707M) : 0, 6706823
master (6.695M) : 0, 6694720
section DD_TRACE_ENABLED=0
master (10.195M) : 0, 10194994
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6475) (9.626M) : 0, 9625630
master (9.350M) : 0, 9350086
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6475) (6.356M) : 0, 6355828
master (6.223M) : 0, 6222880
section Trace stats
master (6.644M) : 0, 6644302
section Manual
master (9.490M) : 0, 9490052
section Manual + Automatic
This PR (6475) (5.939M) : 0, 5938564
master (5.826M) : 0, 5826117
section DD_TRACE_ENABLED=0
master (8.806M) : 0, 8806093
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6475) (9.734M) : 0, 9733803
master (10.038M) : 0, 10038108
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6475) (5.955M) : crit ,0, 5955291
master (6.759M) : 0, 6759031
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.327M) : 0, 7327150
section Manual
master (10.148M) : 0, 10147695
section Manual + Automatic
This PR (6475) (5.705M) : crit ,0, 5705230
master (6.270M) : 0, 6270298
section DD_TRACE_ENABLED=0
master (9.572M) : 0, 9571995
|
Benchmarks Report for tracer 🐌Benchmarks for #6475 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
andrewlock
approved these changes
Dec 23, 2024
| @@ -599,20 +599,20 @@ public static ExplorationTestDescription GetExplorationTestDescription(Explorati | |||
| { | |||
| Name = ExplorationTestName.eShopOnWeb, | |||
| GitRepositoryUrl = "https://github.com/dotnet-architecture/eShopOnWeb.git", | |||
| GitRepositoryTag = "netcore2.1", | |||
| GitRepositoryTag = "main", | |||
There was a problem hiding this comment.
Even so, it probably makes sense to specify the specific commit?
Suggested change
| GitRepositoryTag = "main", | |
| GitRepositoryTag = "2414014bfa0f4d2021b5bc9061429a98d232f440", |
Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
|
there is still an issue on windows with protobuf tests, we have the following error: |
Yikes, that sounds bad. We instrument the testhost, and |
|
it works on Linux though 🙃 |
…ncorrectly + added a test
|
we're getting an error |
GreenMatan
changed the title
vandonr
commented
Jan 13, 2025
vandonr
commented
Jan 13, 2025
vandonr
changed the title
| assembly = Assembly.LoadFile(testAssemblyPath); | ||
| return true; | ||
| } | ||
| catch (BadImageFormatException e) |
There was a problem hiding this comment.
Not a blocker, but this is now causing compiler warnings on master 😅
The variable 'e' is declared but never used
There was a problem hiding this comment.
yeah I saw that... hang in there I'll push a little PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Span<T>assystem.Threading.Thread) which caused bad instrumentation decision to be made. One of them is the usage of by-ref-like types as generic param (to be used by the debugger invokers) and failed withInvalidProgramExceptionbecause by-ref-like is not allowed to be used as generic param.also change the version of those libraries used to have one that's compatible with more recent dotnet versions (this is what revealed the pb mentioned above)
Reason for change
those tests were using netcore 2.1 which we don't actively support anymore, so it makes sense to test them with a supported version.