-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pinned locals parsing + bump dotnet version for protobuf and eShopOnWeb exploration tests #6475
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9017251
bump dotnet version for protobuf and eShopOnWeb exploration tests
vandonr 2a8a42f
remove tag pinning us in the past on eShopOnWeb
vandonr 7773d15
bump proto version used to have one that targets net6
vandonr 305cc70
add git tag as it's required
vandonr 8b7f682
actually use net8 as mentionned in their readme
vandonr cadc39a
pin eShopOnWeb's version to a specific commit
vandonr 07fbe72
use netcoreapp 3.1 for protobuf to see if it helps
vandonr 463cbd0
Merge remote-tracking branch 'origin/master' into vandonr/explo
vandonr fad775b
add ability to target a specific commit rather than a tag for explo t…
vandonr 53dd729
fix git command to reset
vandonr b13fc5a
revert change to netcore31 for proto
vandonr 0fca6f2
Fixed `InvalidProgramException` caused by pinned types being parsed i…
GreenMatan bb0875c
Revert "add ability to target a specific commit rather than a tag for…
vandonr 5034ac5
Revert "pin eShopOnWeb's version to a specific commit"
vandonr 688108a
Fix BadImageException during SetupExplorationTest
dudikeleti 490c240
change load safe to try pattern
dudikeleti 03467be
addressing pr comments
dudikeleti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but this is now causing compiler warnings on
master
😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I saw that... hang in there I'll push a little PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6546
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no rush, thanks!