Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vulnearibilities coming from send module. #2567

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Nov 28, 2022

What does this PR do?

Exclude vulnearibilities coming from send module.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #2567 (4b5a903) into master (a6b86df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2567   +/-   ##
=======================================
  Coverage   87.59%   87.60%           
=======================================
  Files         327      327           
  Lines       11712    11720    +8     
  Branches       33       33           
=======================================
+ Hits        10259    10267    +8     
  Misses       1453     1453           
Impacted Files Coverage Δ
...c/appsec/iast/analyzers/path-traversal-analyzer.js 100.00% <100.00%> (ø)
...rc/appsec/iast/analyzers/vulnerability-analyzer.js 79.06% <100.00%> (+1.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Nov 28, 2022

Benchmarks

Comparing candidate commit 4b5a903 in PR branch julio/feature/path-traversal-exclude-send with baseline commit a6b86df in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 668 metrics, 40 unstable metrics.

@hoolioh hoolioh force-pushed the julio/feature/path-traversal-exclude-send branch from 90e73ac to c7e4add Compare February 9, 2023 14:55
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Overall package size

Self size: 3.98 MB
Deduped: 59.58 MB
No deduping: 59.62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.3.1 13.47 MB 13.47 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@simon-id simon-id added asm-iast and removed asm-waf labels Feb 10, 2023
@simon-id
Copy link
Member

I changed the PR tag as it was the wrong product 👍

@hoolioh hoolioh marked this pull request as ready for review February 13, 2023 09:57
@hoolioh hoolioh requested a review from a team as a code owner February 13, 2023 09:57
@hoolioh hoolioh requested review from uurien and CarlesDD February 16, 2023 11:17
@hoolioh hoolioh force-pushed the julio/feature/path-traversal-exclude-send branch from d25edea to 7f82924 Compare February 17, 2023 16:34
@hoolioh hoolioh force-pushed the julio/feature/path-traversal-exclude-send branch from 25de0d1 to 98715f1 Compare March 29, 2023 08:47
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@hoolioh hoolioh requested a review from iunanua March 29, 2023 10:19
@hoolioh hoolioh dismissed uurien’s stale review March 29, 2023 12:27

Changes already made

@hoolioh hoolioh merged commit ff04754 into master Mar 29, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>
@tlhunter tlhunter deleted the julio/feature/path-traversal-exclude-send branch January 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants