v2.30.0 #2964

tlhunter · 2023-04-03T19:32:02Z

What does this PR do?

[ci-visibility] Improve integration tests (Improve integration tests for CI Visibility #2963)
[core] Preliminary support for bundling via esbuild (support bundling via esbuild #2763)
[appsec] Embed rules and templates files to be compatible with bundlers (Embed AppSec rules and templates files to be compatible with bundlers #2913)
[ci-visibility] Add gatherPayloadsMaxTimeout, a faster version of gatherPayloads ([ci-visibility] Add gatherPayloadsMaxTimeout, a faster version of gatherPayloads #2957)
[iast] Increase timeout for tests on server (Increase timeout for IAST tests on server #2940)
[core] add support for 128-bit trace id (add support for 128-bit trace id #2944)
[data-streams] Return remaining bytes when decoding ([data streams] Return remaining bytes when decoding #2950)
[iast] Exclude vulnerabilities coming from send module. (Exclude vulnearibilities coming from send module. #2567)
[iast] Add support for setting the maximum number of concurrent transactions (Add support for setting the maximum number of concurrent transactions #2926)
[appsec] Update ASM WAF rules to version 1.6.0. (Update ASM WAF rules to version 1.6.0. #2972)
[core] Fix DBM propagation (Fix to DBM propagation - comment is injected before query is sent #2938)
[core] Fix error when using GCP pubsub while plugin is disabled (fix error when using pubsub while plugin is disabled #2966)

…#2926) * Add support for setting the maximum number of concurrent transactions in iast operations. * Update taint tracking module to version 1.3.1.

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>

* Increase timeout for iast tests on server * Put the dependency inside the test

…gatherPayloads` (#2957)

…#2913) * gentle fallback if appsec template files are missing * Load appsec template files with require --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com> Co-authored-by: simon-id <simon.id@datadoghq.com>

tlhunter · 2023-04-03T19:32:52Z

There were some yarn.lock conflicts around eslint/esbuild dependencies. If any failures arise related to them I'll need to modify the esbuild commit.

github-actions · 2023-04-03T19:33:00Z

Overall package size

Self size: 4.02 MB
Deduped: 63.36 MB
No deduping: 63.4 MB

Dependency sizes

name	version	self size	total size
@datadog/native-iast-taint-tracking	1.3.1	13.47 MB	13.47 MB
@datadog/pprof	2.1.0	12.31 MB	13.2 MB
@datadog/native-appsec	2.0.0	12.33 MB	12.34 MB
@datadog/native-metrics	1.5.0	7.1 MB	7.11 MB
protobufjs	7.2.3	2.77 MB	6.65 MB
@types/node	18.11.19	3.58 MB	3.58 MB
@datadog/native-iast-rewriter	2.0.1	2.09 MB	2.1 MB
opentracing	0.14.7	194.81 kB	194.81 kB
lru-cache	7.18.3	133.92 kB	133.92 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
semver	5.7.1	61.58 kB	61.58 kB
ipaddr.js	2.0.1	59.52 kB	59.52 kB
ignore	5.2.4	51.22 kB	51.22 kB
import-in-the-middle	1.3.4	32.7 kB	37.17 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
retry	0.10.1	27.44 kB	27.44 kB
lodash.uniq	4.5.0	25.01 kB	25.01 kB
limiter	1.1.5	23.17 kB	23.17 kB
lodash.kebabcase	4.1.1	17.75 kB	17.75 kB
node-abort-controller	3.1.1	16.89 kB	16.89 kB
lodash.pick	4.4.0	16.33 kB	16.33 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
diagnostics_channel	1.1.0	7.07 kB	7.07 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
methods	1.1.2	5.29 kB	5.29 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2023-04-03T19:37:00Z

Codecov Report

Merging #2964 (8076720) into v2.x (fbc2899) will decrease coverage by 5.72%.
The diff coverage is 77.67%.

@@            Coverage Diff             @@
##             v2.x    #2964      +/-   ##
==========================================
- Coverage   93.51%   87.79%   -5.72%     
==========================================
  Files         222      331     +109     
  Lines        8829    12028    +3199     
  Branches        0       33      +33     
==========================================
+ Hits         8256    10560    +2304     
- Misses        573     1468     +895

Impacted Files	Coverage Δ
integration-tests/ci-visibility/test/sum.js	`69.19% <ø> (ø)`
packages/datadog-instrumentations/src/cucumber.js	`0.00% <0.00%> (-90.77%)`	⬇️
packages/datadog-instrumentations/src/mocha.js	`0.00% <0.00%> (-98.64%)`	⬇️
packages/datadog-instrumentations/src/mongoose.js	`93.33% <ø> (ø)`
packages/datadog-plugin-aws-sdk/src/index.js	`100.00% <ø> (ø)`
packages/datadog-plugin-bunyan/src/index.js	`100.00% <ø> (ø)`
packages/datadog-plugin-connect/src/index.js	`100.00% <ø> (ø)`
packages/datadog-plugin-cucumber/src/index.js	`0.00% <0.00%> (-92.69%)`	⬇️
packages/datadog-plugin-cypress/src/index.js	`100.00% <ø> (ø)`
packages/datadog-plugin-express/src/index.js	`100.00% <ø> (ø)`
... and 89 more

... and 171 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pr-commenter · 2023-04-03T19:39:18Z

Benchmarks

Comparing candidate commit b29f168 in PR branch v2.30.0-proposal with baseline commit ff721f1 in branch v2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 667 metrics, 41 unstable metrics.

tlhunter · 2023-04-03T19:43:59Z

I originally marked the esbuild commit as dont-land-on-v2, but it's probably worth seeing if it at least works.

* Update config.js * Add test to ensure appsec rules are undefined if could not load or parse user rules file * trying to allow non v14 integration tests to run * print node version when esbuild test fails * esbuild refactor broke support for certain node.js versions * display git status when cherry pick fails --------- Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com> Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>

* Update packages/dd-trace/src/appsec/recommended.json --------- Co-authored-by: simon-id <simon.id@datadoghq.com>

) * adding query to async resource to ensure we add the comment before query.apply is called * changing full propagation test to check for comment before call to db

* Update sql-injection-analyzer.js * cleanup

hoolioh and others added 12 commits April 3, 2023 12:22

Add support for setting the maximum number of concurrent transactions (…

2b498f8

…#2926) * Add support for setting the maximum number of concurrent transactions in iast operations. * Update taint tracking module to version 1.3.1.

Exclude vulnearibilities coming from send module. (#2567)

78c4e0f

Co-authored-by: Igor Unanua <igor.unanua@datadoghq.com>

[data streams] Return remaining bytes when decoding (#2950)

9a681b9

Add job to check if PR has merge conflicts with release branches (#2933)

8bf4783

docs: clarifying that ESM support is experimental (#2954)

47c2415

add support for 128-bit trace id (#2944)

d39db8f

Increase timeout for IAST tests on server (#2940)

5421357

* Increase timeout for iast tests on server * Put the dependency inside the test

move slow test framework integration tests to separate jobs (#2955)

2c5dbe7

[ci-visibility] Add gatherPayloadsMaxTimeout, a faster version of `…

da7ea09

…gatherPayloads` (#2957)

support bundling via esbuild (#2763)

b84df7a

Improve integration tests for CI Visibility (#2963)

766039a

tlhunter added the semver-minor label Apr 3, 2023

tlhunter requested review from a team as code owners April 3, 2023 19:32

Only run release branches check on master PRs (#2967)

a6b96cf

tlhunter force-pushed the v2.30.0-proposal branch from 3e2fc07 to b29f168 Compare April 4, 2023 21:21

tlhunter mentioned this pull request Apr 4, 2023

Disable appsec if missing or malformed user custom rules file #2969

Merged

6 tasks

simon-id and others added 4 commits April 5, 2023 09:44

Update ASM WAF rules to version 1.6.0. (#2972)

cc6f223

* Update packages/dd-trace/src/appsec/recommended.json --------- Co-authored-by: simon-id <simon.id@datadoghq.com>

Fix to DBM propagation - comment is injected before query is sent (#2938

81c931e

) * adding query to async resource to ensure we add the comment before query.apply is called * changing full propagation test to check for comment before call to db

fix error when using pubsub while plugin is disabled (#2966)

ba8a6e8

tlhunter force-pushed the v2.30.0-proposal branch from b29f168 to c42a18f Compare April 5, 2023 16:44

skip extraction of upper bits for 64-bit trace id (#2974)

b485168

tlhunter force-pushed the v2.30.0-proposal branch from c42a18f to 8076720 Compare April 5, 2023 20:00

rochdev previously approved these changes Apr 5, 2023

View reviewed changes

simon-id and others added 2 commits April 6, 2023 09:12

Fix #2938 (#2976)

d9493b8

* Update sql-injection-analyzer.js * cleanup

v2.30.0

37a73a0

tlhunter dismissed rochdev’s stale review via 37a73a0 April 6, 2023 16:12

tlhunter force-pushed the v2.30.0-proposal branch from 8076720 to 37a73a0 Compare April 6, 2023 16:12

simon-id approved these changes Apr 6, 2023

View reviewed changes

tlhunter merged commit efe7b3a into v2.x Apr 6, 2023

tlhunter deleted the v2.30.0-proposal branch December 19, 2023 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.30.0 #2964

v2.30.0 #2964

tlhunter commented Apr 3, 2023 •

edited

Loading

tlhunter commented Apr 3, 2023

github-actions bot commented Apr 3, 2023 •

edited

Loading

codecov bot commented Apr 3, 2023 •

edited

Loading

pr-commenter bot commented Apr 3, 2023 •

edited

Loading

tlhunter commented Apr 3, 2023

v2.30.0 #2964

v2.30.0 #2964

Conversation

tlhunter commented Apr 3, 2023 • edited Loading

What does this PR do?

tlhunter commented Apr 3, 2023

github-actions bot commented Apr 3, 2023 • edited Loading

Overall package size

Dependency sizes

codecov bot commented Apr 3, 2023 • edited Loading

Codecov Report

pr-commenter bot commented Apr 3, 2023 • edited Loading

Benchmarks

tlhunter commented Apr 3, 2023

tlhunter commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

codecov bot commented Apr 3, 2023 •

edited

Loading

pr-commenter bot commented Apr 3, 2023 •

edited

Loading