Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when using pubsub while plugin is disabled #2966

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Apr 4, 2023

What does this PR do?

Fix error when using pubsub while plugin is disabled.

Motivation

Fix #2962

@rochdev rochdev requested a review from a team as a code owner April 4, 2023 03:01
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Overall package size

Self size: 4.01 MB
Deduped: 59.61 MB
No deduping: 59.65 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.3.1 13.47 MB 13.47 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2966 (1e98f65) into master (deda0c8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
- Coverage   87.64%   87.63%   -0.01%     
==========================================
  Files         327      329       +2     
  Lines       11746    11747       +1     
  Branches       33       33              
==========================================
  Hits        10295    10295              
- Misses       1451     1452       +1     
Impacted Files Coverage Δ
...atadog-instrumentations/src/google-cloud-pubsub.js 94.11% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2023

Benchmarks

Comparing candidate commit 1e98f65 in PR branch fix-pubsub-v1-error with baseline commit deda0c8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 669 metrics, 39 unstable metrics.

@rochdev
Copy link
Member Author

rochdev commented Apr 4, 2023

The failing system test is unrelated to this PR.

@rochdev rochdev merged commit 8731ea0 into master Apr 5, 2023
@rochdev rochdev deleted the fix-pubsub-v1-error branch April 5, 2023 16:12
This was referenced Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog PubSub integration broken in 3.16
3 participants