Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 128-bit trace id #2944

Merged
merged 5 commits into from
Mar 30, 2023
Merged

add support for 128-bit trace id #2944

merged 5 commits into from
Mar 30, 2023

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 28, 2023

What does this PR do?

Add support for 128-bit trace ID.

Motivation

It's about time.

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Overall package size

Self size: 3.99 MB
Deduped: 59.59 MB
No deduping: 59.63 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.3.1 13.47 MB 13.47 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #2944 (91268a5) into master (913d77c) will increase coverage by 0.27%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
+ Coverage   87.36%   87.63%   +0.27%     
==========================================
  Files         325      327       +2     
  Lines       11585    11746     +161     
  Branches       33       33              
==========================================
+ Hits        10121    10294     +173     
+ Misses       1464     1452      -12     
Impacted Files Coverage Δ
...s/dd-trace/src/opentracing/propagation/text_map.js 96.53% <90.90%> (+0.12%) ⬆️
packages/dd-trace/src/config.js 98.27% <100.00%> (+0.04%) ⬆️
...ckages/dd-trace/src/opentracing/propagation/log.js 100.00% <100.00%> (ø)
packages/dd-trace/src/opentracing/span.js 75.26% <100.00%> (+1.40%) ⬆️
packages/dd-trace/src/opentracing/span_context.js 100.00% <100.00%> (ø)
packages/dd-trace/src/opentracing/tracer.js 98.48% <100.00%> (+0.02%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Mar 28, 2023

Benchmarks

Comparing candidate commit daab5a1 in PR branch 128-bit-trace-id with baseline commit 913d77c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 663 metrics, 45 unstable metrics.

@rochdev rochdev marked this pull request as ready for review March 28, 2023 16:51
@rochdev rochdev requested a review from a team as a code owner March 28, 2023 16:51
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rochdev rochdev merged commit 228d5b1 into master Mar 30, 2023
@rochdev rochdev deleted the 128-bit-trace-id branch March 30, 2023 02:47
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants