Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable 128-bit trace id tests for node #1013

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 28, 2023

Description

Enable 128-bit trace ID tests for Node.

Related: DataDog/dd-trace-js#2944

Workflow

  1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! ❤️

Verified

This commit was signed with the committer’s verified signature.
rochdev Roch Devost
@rochdev
Copy link
Member Author

rochdev commented Mar 29, 2023

This is now ready for review as all tests pass locally and we'd like to be able to also run them in CI before merging/releasing the functionality.

@rochdev rochdev marked this pull request as ready for review March 29, 2023 15:36
@rochdev rochdev requested review from Kyle-Verhoog and a team as code owners March 29, 2023 15:36
@cbeauchesne
Copy link
Collaborator

cbeauchesne commented Mar 30, 2023

This is now ready for review as all tests pass locally and we'd like to be able to also run them in CI before merging/releasing the functionality.

Hi Roch,

Do you mean that you want to merge the PR in system test before yours ? (if yes, it means that it'll break your CI until you have merged yours).

An alternative way is to pull this branch rather thn main in your PR.

@rochdev
Copy link
Member Author

rochdev commented Apr 4, 2023

We're actually close to releasing the feature, so as long as this is approved we should be able to merge within a couple of days.

@rochdev
Copy link
Member Author

rochdev commented Apr 6, 2023

@cbeauchesne The feature was now released in the latest version of dd-trace-js, so this can now also be merged.

@rochdev rochdev merged commit 5a5a937 into main Apr 12, 2023
@rochdev rochdev deleted the rochdev/enable-nodejs-128bit-traceid branch April 12, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants