-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Add gatherPayloadsMaxTimeout
, a faster version of gatherPayloads
#2957
[ci-visibility] Add gatherPayloadsMaxTimeout
, a faster version of gatherPayloads
#2957
Conversation
Overall package sizeSelf size: 4 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
+ Coverage 87.63% 91.07% +3.43%
==========================================
Files 327 266 -61
Lines 11746 9782 -1964
Branches 33 33
==========================================
- Hits 10294 8909 -1385
+ Misses 1452 873 -579 see 61 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gatherPayloads
named gatherPayloadsMaxTimeout
gatherPayloadsMaxTimeout
, a faster version of gatherPayloads
1161b6b
to
394e47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress makes me sad.
What does this PR do?
Its API is a bit clumsier (callback vs promise) so I'm going to leave
gatherPayloads
for situations where timing is not that much of an issue.Motivation
Make sure some browser test checks finish as soon as possible, not after the gathering time has passed.
Examples
Before
After