Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Add gatherPayloadsMaxTimeout, a faster version of gatherPayloads #2957

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Mar 30, 2023

What does this PR do?

Its API is a bit clumsier (callback vs promise) so I'm going to leave gatherPayloads for situations where timing is not that much of an issue.

Motivation

Make sure some browser test checks finish as soon as possible, not after the gathering time has passed.

Examples

Before

After

@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Overall package size

Self size: 4 MB
Deduped: 59.59 MB
No deduping: 59.64 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.3.1 13.47 MB 13.47 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2957 (394e47c) into master (bb61b06) will increase coverage by 3.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
+ Coverage   87.63%   91.07%   +3.43%     
==========================================
  Files         327      266      -61     
  Lines       11746     9782    -1964     
  Branches       33       33              
==========================================
- Hits        10294     8909    -1385     
+ Misses       1452      873     -579     

see 61 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Mar 30, 2023

Benchmarks

Comparing candidate commit 1161b6b in PR branch juan-fernandez/improve-gather-payloads with baseline commit 228d5b1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 666 metrics, 42 unstable metrics.

@juan-fernandez juan-fernandez changed the title [ci-visibility] Add faster version of gatherPayloads named gatherPayloadsMaxTimeout [ci-visibility] Add gatherPayloadsMaxTimeout, a faster version of gatherPayloads Mar 30, 2023
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/improve-gather-payloads branch from 1161b6b to 394e47c Compare March 30, 2023 14:21
@juan-fernandez juan-fernandez marked this pull request as ready for review March 30, 2023 14:27
@juan-fernandez juan-fernandez requested a review from a team as a code owner March 30, 2023 14:27
Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress makes me sad.

@juan-fernandez juan-fernandez merged commit deda0c8 into master Mar 30, 2023
@juan-fernandez juan-fernandez deleted the juan-fernandez/improve-gather-payloads branch March 30, 2023 14:43
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants