Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the maximum number of concurrent transactions #2926

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Mar 23, 2023

What does this PR do?

Modify the maximum number of transactions accordingly with the maximum number of concurrent request.

@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Overall package size

Self size: 3.98 MB
Deduped: 59.58 MB
No deduping: 59.62 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.3.1 13.47 MB 13.47 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Mar 23, 2023

Benchmarks

Comparing candidate commit b382192 in PR branch julio/set-concurrent-requests with baseline commit f493b19 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 672 metrics, 36 unstable metrics.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2926 (b382192) into master (f493b19) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
- Coverage   87.59%   87.59%   -0.01%     
==========================================
  Files         327      327              
  Lines       11708    11712       +4     
  Branches       33       33              
==========================================
+ Hits        10256    10259       +3     
- Misses       1452     1453       +1     
Impacted Files Coverage Δ
packages/dd-trace/src/appsec/iast/index.js 100.00% <100.00%> (ø)
...s/dd-trace/src/appsec/iast/taint-tracking/index.js 100.00% <100.00%> (ø)
...trace/src/appsec/iast/taint-tracking/operations.js 98.07% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoolioh hoolioh force-pushed the julio/set-concurrent-requests branch from d716be0 to 34553d0 Compare March 27, 2023 10:32
@hoolioh hoolioh force-pushed the julio/set-concurrent-requests branch from f01c9cb to 45bf1a8 Compare March 29, 2023 08:34
@hoolioh hoolioh marked this pull request as ready for review March 29, 2023 08:45
@hoolioh hoolioh requested review from a team as code owners March 29, 2023 08:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changes the registry of the whole file.
I would try to delete your yarn.lock and execute again yarn. I guess there should be only one change related with the @datadog/native-iast-taint-tracking version update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, although there is another package updated (pprof) don't know why

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they forget to update the yarn.lock when they changed the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is likely the case. Nicolas was the one that updated it.

@hoolioh hoolioh force-pushed the julio/set-concurrent-requests branch from 45bf1a8 to db8b6ee Compare March 29, 2023 10:26
@hoolioh hoolioh force-pushed the julio/set-concurrent-requests branch from db8b6ee to b382192 Compare March 29, 2023 10:33
@hoolioh hoolioh merged commit a6b86df into master Mar 29, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
…#2926)

* Add support for setting the maximum number of concurrent transactions in iast operations.

* Update taint tracking module to version 1.3.1.
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 3, 2023
…#2926)

* Add support for setting the maximum number of concurrent transactions in iast operations.

* Update taint tracking module to version 1.3.1.
@tlhunter tlhunter mentioned this pull request Apr 3, 2023
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
…#2926)

* Add support for setting the maximum number of concurrent transactions in iast operations.

* Update taint tracking module to version 1.3.1.
tlhunter pushed a commit that referenced this pull request Apr 6, 2023
…#2926)

* Add support for setting the maximum number of concurrent transactions in iast operations.

* Update taint tracking module to version 1.3.1.
@tlhunter tlhunter deleted the julio/set-concurrent-requests branch January 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants