Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.24.0 proposal #3966

Merged
merged 14 commits into from
Jan 17, 2024
Merged

V4.24.0 proposal #3966

merged 14 commits into from
Jan 17, 2024

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Jan 15, 2024

Features

Improvements

nsavoire and others added 12 commits January 15, 2024 15:58
* Add CPU profiler

* Avoid restarting profiling for last collect

Upon process exit, profiler collects profiles a last time and was
restarting all profilers before stopping them.
Avoid this useless restart by changing the profiler API and make
`profile()` methode take a restart argument.

* Bump pprof-nodejs version
* set limiter version to 1.1.5

* reorder packages list

* update import-in-the-middle lockfile entry
---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
* Update Next.js tests to work with Node 18

---------

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
@szegedi szegedi requested a review from a team as a code owner January 15, 2024 15:30
Copy link

github-actions bot commented Jan 15, 2024

Overall package size

Self size: 5.83 MB
Deduped: 61.48 MB
No deduping: 62.24 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.2 45.99 kB 709.38 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4.x@909d99d). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v4.x    #3966   +/-   ##
=======================================
  Coverage        ?   85.02%           
=======================================
  Files           ?      238           
  Lines           ?    10191           
  Branches        ?       33           
=======================================
  Hits            ?     8665           
  Misses          ?     1526           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juan-fernandez
juan-fernandez previously approved these changes Jan 15, 2024
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from ci vis perspective

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2024

Benchmarks

Benchmark execution time: 2024-01-17 10:41:01

Comparing candidate commit e47cbb3 in PR branch v4.24.0-proposal with baseline commit 909d99d in branch v4.x.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 780 metrics, 16 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-137.016MB; -84.484MB] or [-14.447%; -8.908%]

scenario:plugin-q-with-tracer-16

  • 🟩 instructions [-207.9M instructions; -147.9M instructions] or [-11.239%; -7.996%]

* fix failing Nextjs tests on Node versions < 18

* address feedback
@szegedi szegedi merged commit 7971eaa into v4.x Jan 17, 2024
@szegedi szegedi deleted the v4.24.0-proposal branch January 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants