-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROF-9374: Move timeline events serialization from the hot path #4173
Conversation
Overall package sizeSelf size: 6.24 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4173 +/- ##
==========================================
+ Coverage 85.06% 85.22% +0.15%
==========================================
Files 247 247
Lines 10953 10948 -5
Branches 33 33
==========================================
+ Hits 9317 9330 +13
+ Misses 1636 1618 -18 ☔ View full report in Codecov by Sentry. |
2b50f29
to
a391713
Compare
BenchmarksBenchmark execution time: 2024-03-21 10:35:32 Comparing candidate commit 586c2e8 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 7 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
…Makes the operation more predictable, and in practice there'll be events.
…ntered; this keeps the string table potentially smaller
2fb22ad
to
586c2e8
Compare
No real changes, just resolved conflicts with #4146 |
What does this PR do?
Moves the conversion of performance events into pprof samples from being performed in bulk at the
profile
call to being performed in event handler callback.Motivation
Profile serialization and encoding are CPU intensive and contribute to latency spikes when we prepare pprof files for upload. Moving as much processing out of that code path reduces those latency spikes. The cost will now instead be amortized across
PerformanceObserver
callbacks.Additional Notes
I added some of the relevant commits from the approved #4149. I don't want to merge all of #4149 until we are happy with the latencies.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.